search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
455 stars 603 forks source link

Renovator - Dry Run option Check/UnCheck results in always running a dry run. #1789

Closed singhsukhraj closed 5 years ago

singhsukhraj commented 5 years ago

Required Information

Expected Behavior

Please describe briefly the expected behavior, i.e. when I do X, Y should happen. Checking/Uncheck of DRY run option doesn't do anything. The result is always : Renovator DRY RUN: Publish mode self_managed and no actual assets movement take place.

Actual Behavior

Please describe briefly the actual behavior, i.e. when I do X, Z happens. Unchecking DRY run option should result in actual movement of Assets.

Steps to Reproduce

Starting from a vanilla instance of AEM at the above version, describe in explicit steps how to reproduce. Link to any supporting assets, e.g. content packages, below Instead of using a spreadsheet , use source and destination options. Example - Source - /content/dam/level1 Destination-/content/dam/level2 Uncheck all other option that is , Publish -None Create version - Uncheck Update Status - Uncheck Extensive ACL check -UnCheck Dry Run -Uncheck Detailed Report- Uncheck.

Links

Links to related assets, e.g. content packages containing test components NA

badvision commented 5 years ago

Interesting. Will have a look. Thanks!

badvision commented 5 years ago

This only happens if you check and then uncheck but not if you leave the box unchecked, right?

singhsukhraj commented 5 years ago

By default the dry run checkbox is checked, so we will not able to leave the box unchecked.

badvision commented 5 years ago

1808 should fix this