I18NInjector is called on Object field in SlingModel

[beo4]

Required Information

• [ x] AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.4.4
• [ x] ACS AEM Commons Version: 4.4.0
• [ x] Reproducible on Latest? yes

Expected Behavior

A String or String Array should be handed over to Object Filed in a SlingModel

Actual Behavior

After handing over a htl Parameter to an Object in class I18N Object gets injected

Steps to Reproduce

See https://github.com/eggsunimediaGmbH/acs-commons/blob/master/core/src/test/java/de/eggs/core/models/HelloWorldModelTest.java

Links

https://github.com/eggsunimediaGmbH/acs-commons/blob/master/core/src/test/java/de/eggs/core/models/HelloWorldModelTest.java

[joerghoh]

For some reasons the 18NInjector handles the adaptions to Object, which is unexpected if you come from older versions of ACS AEM Commons, where this Injector isn't part of.

One option would be to change the service ranking, another to disable all custom injectors by default (and requiring an available configuration, as we do with other services as well).

On the other hand one could argue, that injecting an Object is very uncommon per se, and shouldn't be done at all; and if you have to use it, you have to use @Source and define which injector you want to use. In that case the current code is ok, but we should extend the documentation for this specific case.

@davidjgonzalez @badvision WDYT?

[joerghoh]

I would tend to the suggestion 2 (leave it as is and improve the documentation); injecting Object references might not only lead to issues with the I18Injector, but also with others; thus annotating it with the type of the injector you expect to provide the injection is probably the best way to go forward.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.