search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 598 forks source link

ScrMetadataIT always compares with latest release #2472

Open kwin opened 3 years ago

kwin commented 3 years ago

The test in com.adobe.acs.commons.it.build.ScrMetadataIT always compares with metadata from the latest ACS Commons release. Instead it should compare with the latest release version which is smaller than the current snapshot. We currently have build failures in https://github.com/Adobe-Consulting-Services/acs-aem-commons/tree/feature/2288-prepare-release-500 due to that (as that is still based on 4.8.6-SNAPSHOT). Only that way parallel evolution of two major releases is properly supported.

kwin commented 3 years ago

An algorithm like https://github.com/bndtools/bnd/blob/885ee4045ab3ffe4205473063c8f7f8b42c9abfa/maven/bnd-baseline-maven-plugin/src/main/java/aQute/bnd/maven/baseline/plugin/BaselineMojo.java#L210 is necessary to determine the base version correctly.

kwin commented 3 years ago

Probably injecting the version with https://www.mojohaus.org/versions-maven-plugin/update-property-mojo.html is the easiest approach.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.