search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
454 stars 600 forks source link

Dispatcher Flush Rules - Not compatible with Dispatcher Flush Refetch configuration #2478

Open shashimuluguaem opened 3 years ago

shashimuluguaem commented 3 years ago

Required Information

Expected Behavior

I have configured ACS commons Dispatcher Flush Rules on AEM 6.4 instance and everything is working fine till i changed my Flush agent to Re-fetch Flush Agent.

Actual Behavior

Re-fetch Flush Agent is not being invoked for the rules configured in ACS Commons Flush Rules

shashimuluguaem commented 3 years ago

@davidjgonzalez @justinedelson Any Help here?

davidjgonzalez commented 3 years ago

@shashimuluguaem What's the Serialization Type for refetch? Is it "flush"? If not, that won't work without some code adjustments. Do you happen to know what the value of the Refetch serialization type is?

joseqwd commented 3 years ago

Hi @davidjgonzalez

To respond to your question, on our ContentBuilder implementation for re-fetch we are using a different name instead of flush. When we tried with flush it doesn't get registered and is not available as a serialization type option in the Agent configuration. Any suggestions?

atopper commented 3 years ago

I have just been working on this topic for a certain customer (activating a lot of DAM Assets, using Rules to invalidate (evict) dispatcher cache pages during a high traffic times which swamps the Publisher). At this stage I'd like to eventually propose a PR to this repo. Is there anyone who I should be communicating with for this?

Looks like this was considered before: https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/143

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.