ACS Reports - Page replication status always NOT_ACTIVATED when downloading report as csv

Semperdecus commented 3 years ago

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM 6.4.8.2, AEM 6.4 Service Pack 8 (6.4.8.0)
[ ] ACS AEM Commons Version: 4.8.0, also tried 4.11.3
[ ] Reproducible on Latest? yes

Expected Behavior

When I use ACS reports to build a new report and use the replication status component in the report columns, I get correct replication status when exporting to csv.

Actual Behavior

When I use ACS reports to build a new report and use the replication status component in the report columns, I do NOT get correct replication status when exporting to csv. The status us always "NOT_ACTIVATED"

The webpage works fine:

Steps to Reproduce

The issue can be replicated in vanilla AEM and latest ACS with a custom report to check for any property value and that has replication status as a report column. The replication status is always NOT_ACTIVATED.

Links

Reported previously, but always auto-closed:

https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2333 https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2115 https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/1399

Concerning this class: https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/reports/models/PageReplicationStatusModel.java

Possible solution

In PageReplicationStatusModel.java line 71 the path is always the same and does not use the proper resource. A dirty fix is to change the getValue (line 103) method in PageReplicationStatusModel.java:

From:

  @Override
  public String getValue(Object result) {
    return getReplicationStatus();
  }

To:

  @Override
  public String getValue(Object result) {
    resource = (Resource) result;
    return getReplicationStatus();
  }

DasAnk commented 2 years ago

This issue is reproducible on 5.0.6 (version I checked with). If the possible solution above is the fix, could this be baked into the product?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Adobe-Consulting-Services / acs-aem-commons