search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 600 forks source link

Deprecation warnings from aemanalyser-maven-plugin #2592

Open kwin opened 3 years ago

kwin commented 3 years ago

Required Information

Expected Behavior

No warning when embedding ACS AEM Commons in a container package which is checked with aemanalyser-maven-plugin.

Actual Behavior

The following warnings are emitted

[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Bundle acs-aem-commons-bundle:5.0.4 is importing package(s) [org.apache.http.config, com.github.benmanes.caffeine.cache.stats, org.apache.tika.parser.html, org.apache.http, org.apache.http.entity, org.apache.http.message, org.apache.http.ssl, com.github.benmanes.caffeine.cache] without specifying a version range. 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.lang.text : Please use Apache Commons Lang 3 instead. 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.lang.builder : Please use Apache Commons Lang 3 instead. 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.lang : Please use Apache Commons Lang 3 instead. 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.lang.reflect : Please use Apache Commons Lang 3 instead. 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.sling.settings : Avoid these features at runtime: run modes, file system access 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.sling.commons.auth : Use Apache Sling's org.apache.sling.auth.core package instead.
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.lang.time : Please use Apache Commons Lang 3 instead. 
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.collections.iterators : Please use Apache Commons Collections 4 instead.
[WARNING] com.adobe.acs:acs-aem-commons-bundle:5.0.4: Usage of deprecated package found : org.apache.commons.collections : Please use Apache Commons Collections 4 instead.

Steps to Reproduce

Just add the package acs-aem-commons-content as embedded package to a container which which is afterwards checked with aemanalyser-maven-plugin

Links

The analyser in https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/48baf1eefeadd5eb9f680b34bc6e547a7bdec82b/src/main/java/org/apache/sling/feature/extension/apiregions/analyser/CheckDeprecatedApi.java#L38 emits those warning.

Also https://experienceleague.adobe.com/docs/experience-manager-cloud-service/release-notes/deprecated-apis.html?lang=en outlines the decommision of the deprecated APIs.

kwin commented 3 years ago

Commons Lang3 (3.6.0), Commons Collection4 (4.1.0) and Sling Auth Core (1.4.2) are available in AEM 6.4.0+ so it should be safe to migrate. For org.apache.sling.settings (compare with #2476) is is not clear how to replace it!

kwin commented 3 years ago

I would like to base this work on https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2422/files. @davidjgonzalez Can we switch to 6.0.0 now? The more we work on 5.x.x the more work we have to invest on 6.0.0

kwin commented 3 years ago

@davidjgonzalez Ping again about switching to 6.x branch. Target removal date of deprecated packages in AEMaaCS comes closer....

kwin commented 3 years ago

@davidjgonzalez Only 4 weeks until ACS AEM Commons stops working in AEMaaCS. Can we switch to the 6.0.0 branch?

kwin commented 3 years ago

@davidjgonzalez A bit more than 1 week until it is supposed to break deployment in AEMaaCS according to https://experienceleague.adobe.com/docs/experience-manager-cloud-service/release-notes/deprecated-apis.html?lang=en. Any suggestions on how to proceed with switching to the 6.x branch?

kwin commented 3 years ago

Replacement of org.apache.sling.commons.auth is now tracked in #2685.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.