Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 600 forks source link

REDIRECT MAP EDIT FUNCTIONALITY NOT WORKING #2632

Closed Sagarmcapgemini12 closed 3 years ago

Sagarmcapgemini12 commented 3 years ago

Required Information

Expected Behavior

when we create a rule and refresh we will get an edit option to change the rule which can be edited and saved

Actual Behavior

when we click on edit button we are unable to change the rule and also delete the rule

Steps to Reproduce

create a rule in redirect map refresh click on edit option image try to change/delete rule image the dialog popup is empty

Links

Links to related assets, e.g. content packages containing test components

YegorKozlov commented 3 years ago

Which browser/OS? Editing redirects works fine in Chrome and FF on my Windows 10 laptop. Please press F12 and check the error messages.

Sagarmcapgemini12 commented 3 years ago

i am using chrome Version 91.0.4472.114 (Official Build) (64-bit) and windows 10 i dont see any errors on the console when we click on the edit the dialog is empty

YegorKozlov commented 3 years ago

Click View Source and find the redirect which opens the blank dialog e.g.

<tr is="coral-table-row" id="redirect-rule-3" data-path="/conf/we-retail/settings/redirects/redirect-rule-3">
  | <td is="coral-table-cell">
  | <a class="coral-Link edit-redirect-rule" href="#" target="_blank"><coral-icon icon="edit" size="XS"></coral-icon></a>
  | </td>
  | <td is="coral-table-cell" class="source" data-value="/content/we-retail/es_IB">
  | /content/we-retail/es_IB
  | </td>
  | <td is="coral-table-cell" class="target" data-value="/content/we-retail/en_GB">
  | /content/we-retail/en_GB
  | </td>
  | <td is="coral-table-cell" class="statusCode" data-value="302" style="width:50px;">302</td>
  | <td is="coral-table-cell" class="untilDate" style="width:120px;"></td>
  | <td is="coral-table-cell" class="note" style="width:150px;"></td>
  | <td is="coral-table-cell">
  | <button is="coral-button" type="button" variant="minimal" icon="dragHandle" coral-table-roworder title="drag to re-arrange"></button>
  | </td>
  | </tr>
  |  

The data-value attributes are loaded into the Edit dialog. Are they present? Also, notice the data-path="/conf/we-retail/settings/redirects/redirect-rule-3" attribute. Please provide the json dump of this node, e.g. http://localhost:4502/conf/we-retail/settings/redirects/redirect-rule-3.tidy.-1.json

{
"jcr:primaryType": "nt:unstructured",
"source": "/content/we-retail/es_IB",
"target": "/content/we-retail/en_GB",
"statusCode": "302",
"sling:resourceType": "acs-commons/components/utilities/manage-redirects/redirect-row"
}
YegorKozlov commented 3 years ago

And please try out the latest build from trunk. There was quite a bit of changes in the Redirect Manager tool.

Sagarmcapgemini12 commented 3 years ago

i am checking in 5.0.5 as well i see the same issue josn dump { "jcr:primaryType": "sling:OrderedFolder", "jcr:createdBy": "admin", "source": "/content/we-retail/en_CA", "target": "/content/we-retail/de_DE", "jcr:created": "Thu Jul 01 2021 18:55:04 GMT+0530", "statusCode": "302", "sling:resourceType": "acs-commons/components/utilities/manage-redirects/redirect-row" }

and the data path attribute is not present

302 (Temporarily Moved) 301 (Permanently Moved)
YegorKozlov commented 3 years ago

Is it the default global configuration or per-context? 5.0.5 should move your redirects from /var to /conf and display a message. Did it happen? Is there any difference in editing a moved redirect and a brand new one, created in 5.0.5?

I can't reproduce it on my local. Tried Chrome, FF and Edge. Everything is clockwork.

Sagarmcapgemini12 commented 3 years ago

Yes the redirects are moved to /conf and also the context aware mapping is used i have added the conf propert as well the redirections are working fine but only the edit has issues i observed this in my colleague's machine as well just installed the 5.0.4 version package and added a rule when we try to edit it back it has issues

YegorKozlov commented 3 years ago

Are you accessing https://localhost:4502 or your AEM is behind dispatcher? I'm guessing what could cause the trouble.

I've just tried on a Vanilla AEM 6.5+ACS Commons Build from trunk. Chrome 91.0.4472.114 opens the Edit dialog just fine.

Sagarmcapgemini12 commented 3 years ago

i am checking in my local and also our environment both has the same issues can you check in some other system just install the package create a rule and try to edit

YegorKozlov commented 3 years ago

please attach the entire html of the page. view-source:http://localhost:4502/apps/acs-commons/content/redirect-manager.html/conf/we-retail/settings/redirects

I tried on a Ubuntu laptop and it worked fine as well. Both Chrome and FF. Also tried my local AEM from my cell, also went fine.

Please try clearing your browser cache. Please try it in the Incognito mode.

Sagarmcapgemini12 commented 3 years ago

<!DOCTYPE html>

Adobe Experience Manager / ACS AEM Commons / Manage Redirects
Manage Redirects Redirect Configurations
Manage Export Import Publish Configure Redirection Rule
302 (Temporarily Moved) 301 (Permanently Moved)


Edit Redirect From Redirect To Status Code Until Date Notes
/content/career/en/develop-faster /content/career/de/schneller-entwickeln 302

Export Redirect Map

Export combined redirect map into Excel spreadsheet. You can edit it offline and upload the redirect configurations using the Import option.

Import Redirect Map

The redirect map file will be combined with the redirects configured in AEM to create the final set of redirects. This file should be a spreadsheet file with the first column containing the source path, the second column containing the redirect destination and the third column containing the redirect status code.

Last Published: by

Sagarmcapgemini12 commented 3 years ago

Tried in incognito and FF as well same issues

YegorKozlov commented 3 years ago

still can't reproduce it.

Are you running vanilla 6.5 ? Any service packs applied? Any customizations of Adobe Granite HTML Library Manager?

how many redirects do you have? a few or thousands?

please zip the /conf/global/settings/redirects and attach to this ticket.

Sagarmcapgemini12 commented 3 years ago

confglobal_package.zip image image

YegorKozlov commented 3 years ago

tried as I would, I still can't reproduce it. image

BTW, I don't see the "Strict Versioning" options on my local 6.5 instance. it's not present on vanilla 6.5, nor on 6.5+SP6.5.9 Are you running classic AEM of AEM as a Cloud Service ?

I tested quite a bit of browser/OS and editing redirects works fine everywhere:

Sagarmcapgemini12 commented 3 years ago

Yes i am using classic AEM of AEMaaCS

YegorKozlov commented 3 years ago

I'd like to look at the complete page html. There must be differences in the client libraries.

Please navigate http://localhost:4502/apps/acs-commons/content/redirect-manager.html/conf/global/settings/redirects Right mouse click then Save as / Web Page Complete Zip the page and its dependencies and attach to this ticket.

Sagarmcapgemini12 commented 3 years ago

New folder.zip

YegorKozlov commented 3 years ago

Bingo! I was able to reproduce it. AEMaaCS uses a newer version of the Coral UI library which generates a slightly different html. To fill in the dialog with values the code looks up the table row :

var tr = $(this).parents('.coral-Table-row'); which returns null in AEMaaCS . Somehow the '.coral-Table-row' style is not set.

The fix is coming.

YegorKozlov commented 3 years ago

https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2643

YegorKozlov commented 3 years ago

Getting the fix in master may take a few days. For now you can try https://github.com/YegorKozlov/acs-aem-commons/tree/issue_2632

Sagarmcapgemini12 commented 3 years ago

I observed the same issue in touchui-composite-multifield-nodestore.js when we use a multi field with acs-commons-nested as NODE_STORE the values are not getting saved

image