search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 600 forks source link

Code smells in the code quality scanning #2802

Open epcy2809 opened 2 years ago

epcy2809 commented 2 years ago

Upon using this bundle in our project gives the below code smells in the code quality pipeline.

We have the below Critical and Major issues being captured in the AEM as cloud service code qulaity pipeline. Beacuse of which our code quality is score.

adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface com.day.cq.replication.Replicator annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.mcp.impl.processes.renovator.ReplicatorQueue contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface org.apache.sling.api.SlingHttpServletRequest annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.redirectmaps.impl.FakeSlingHttpServletRequest contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface com.day.cq.search.Query annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.search.CloseableQuery contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface org.apache.sling.api.request.RequestPathInfo annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.synth.impl.SynthesizedSlingHttpServletRequest$WrappedRequestPathInfo contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface org.apache.sling.api.request.RequestPathInfo annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.wcm.vanity.impl.ExtensionlessRequestWrapper$RequestPathInfoWrapper contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface com.adobe.granite.workflow.exec.WorkItem annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.workflow.synthetic.impl.granite.SyntheticWorkItem contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface com.adobe.granite.workflow.WorkflowSession annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.workflow.synthetic.impl.granite.SyntheticWorkflowSession contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-commons-ui.apps:5.0.4 The product interface com.day.cq.search.Query annotated with @ProviderType should not be implemented by custom code. Detected in com.adobe.acs.commons.wrap.cqsearch.QueryIWrap contained in /apps/acs-commons/install/acs-aem-commons-bundle-5.0.4.jar. Bug Critical 30m CQRules:CQBP-84 cqsoftwarequality https://www.adobe.com/go/aem_cmcq_cqbp-84_en adobe/consulting:acs-aem-tools-content:1.0.2 Node /apps/acs-tools/config is an OSGi config or install path which contains non-OSGi-related children that will not be visible to non-administrative users. Bug Major ConfigAndInstallShouldOnlyContainOsgiNodes aem https://www.adobe.com/go/aem_cmcq_configandinstallshou_en adobe/consulting:acs-aem-tools-content:1.0.2 Node /apps/acs-tools/install is an OSGi config or install path which contains non-OSGi-related children that will not be visible to non-administrative users. Bug Major ConfigAndInstallShouldOnlyContainOsgiNodes aem https://www.adobe.com/go/aem_cmcq_configandinstallshou_en

We need this issue to be fixed to improve our code quality score.

THanks!

shamrox commented 2 years ago

I agree 100% on this

shamrox commented 2 years ago

I am using 5.2.0 ang

adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/packager/query-packager/configuration has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/workflow/select-agent has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/packager/authorizable-packager/configuration has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/errorpagehandler has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/content/long-form-text has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/sharethispage has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/typekitpage has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/dtmpage has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/designer/clientlibsmanager has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/content/generic-text has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/content/audio has a Classic UI design dialog, but no corresponding Touch UI design dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/content/column-control has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/workflow/watson-audio-transcription has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/genericlist/item has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/packager/acl-packager/configuration has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/utilities/packager/asset-packager/configuration has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 Component /apps/acs-commons/components/content/generic-text-image has a Classic UI dialog, but no corresponding Touch UI dialog. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/named-transform-image extends the legacy foundation component foundation/components/image. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/generic-text-image extends the legacy foundation component foundation/components/textimage. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/sharethis-buttons extends the legacy foundation component foundation/components/parbase. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/generic-text extends the legacy foundation component foundation/components/text. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/audio extends the legacy foundation component foundation/components/parbase. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/long-form-text/long-form-text-parsys extends the legacy foundation component foundation/components/parsys. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/long-form-text/long-form-text-parsys/new extends the legacy foundation component foundation/components/parsys/new. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/column-control extends the legacy foundation component foundation/components/parbase. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/definition-list extends the legacy foundation component foundation/components/parbase. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/base/ajax extends the legacy foundation component foundation/components/parbase. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/content/sharethis-counts extends the legacy foundation component foundation/components/parbase. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/page extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/app-page extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/designer extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/report-builder/report-list-page transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/report-builder/report-page transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/exporters/tags-to-csv transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/exporters/users-to-csv transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/audit-log-search transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/version-replicator transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/qr-code transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/jcr-compare transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/bulk-workflow-manager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/automatic-package-replication transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/oak-index-manager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/sort-nodes transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/instant-package transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/redirectmappage transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/dispatcher-flush transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/asset-packager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/asset-packager/configuration transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/query-packager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/query-packager/configuration transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/acl-packager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/acl-packager/configuration transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/authorizable-packager transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/packager/authorizable-packager/configuration transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 The component /apps/acs-commons/components/utilities/system-notifications transitively extends the legacy foundation component foundation/components/page. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/asset-selectors/ms-office/template/page is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/genericlist is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/asset-packager is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/exporters/tags-to-csv is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/exporters/users-to-csv is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/query-packager is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/sharethis is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/dispatcher-flush is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/typekit is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/bulk-workflow-manager is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/marketocloudconfig is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/automatic-package-replication is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/dtm is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/acl-packager is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/redirectmap is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/authorizable-packager is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor adobe/consulting:acs-aem-commons-ui.apps:5.2.0 0 /apps/acs-commons/templates/utilities/system-notifications is a Static Template under /apps. The use of Editable Templates is recommended. Code Smell Minor

davidjgonzalez commented 2 years ago

@epcy2809 the critical issues are fixed in the latest. The Code Smell Minors @shamrox pointed out will require a more drastic solution, which i expect will be removing or re-writing most of these featured from ACS Commons (many are deprecated anyhow)