search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 599 forks source link

Cloud Manager deployment minor issues in the build report #3093

Open adellanegra opened 1 year ago

adellanegra commented 1 year ago

Required Information

Expected Behavior

no issues in the build project report

Actual Behavior

I am working on AEM as a Cloud Service and following the documentation https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html I have included in the pom files the dependencies for installing the acs commons automatically in the build process.

The deployment via cloud service finishes correctly but the code quality step reports almost 42 minor issues related to the templates and the components included in the packages. Below the issues:

/apps/acs-commons/asset-selectors/ms-office/template/page is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/genericlist is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/asset-packager is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/exporters/tags-to-csv is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/exporters/users-to-csv is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/query-packager is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/dispatcher-flush is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/bulk-workflow-manager is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/marketocloudconfig is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/automatic-package-replication is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/acl-packager is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/redirectmap is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/authorizable-packager is a Static Template under /apps. The use of Editable Templates is recommended.
/apps/acs-commons/templates/utilities/system-notifications is a Static Template under /apps. The use of Editable Templates is recommended.
Inclusion of both /etc/packages/adobe/consulting/acs-aem-commons-ui.apps-6.0.6.zip/jcr:content and /apps/acs-commons in the same package violates the separation of immutable and mutable paths in the same package.
The component /apps/acs-commons/components/content/named-transform-image extends the legacy foundation component foundation/components/image.
The component /apps/acs-commons/components/content/twitter-feed extends the legacy foundation component foundation/components/parbase.
The component /apps/acs-commons/components/utilities/twitter-rate-limit-checker extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/page extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/app-page extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/report-builder/report-list-page transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/report-builder/report-page transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/exporters/tags-to-csv transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/exporters/users-to-csv transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/audit-log-search transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/version-replicator transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/qr-code transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/jcr-compare transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/bulk-workflow-manager transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/automatic-package-replication transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/sort-nodes transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/instant-package transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/redirectmappage transitively extends the legacy foundation component foundation/components/page.
The component /apps/acs-commons/components/utilities/dispatcher-flush transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/packager transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/packager/asset-packager transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/packager/query-packager transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/packager/acl-packager transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/packager/authorizable-packager transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.
The component /apps/acs-commons/components/utilities/system-notifications transitively extends the legacy foundation component /libs/wcm/foundation/components/basicpage/v1/basicpage.

The current acs commons version is still using static templates and legacy components; are you planning to covert them to compatible and new version or shoud I ignore those warnings?

Steps to Reproduce

https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html and trigger the deployment via cloud manager

davidjgonzalez commented 1 year ago

@adellanegra you can ignore those warnings. We currently dont have plans moving them over to Editable Templates as that would only add to the complexity of those features with no benefit (other than eliminating those warnings).