search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
454 stars 599 forks source link

Content in /apps (that is not of ACS AEM Commons) gets overwritten (should be kept) #3203

Open henrykuijpers opened 12 months ago

henrykuijpers commented 12 months ago

Required Information

Expected Behavior

Content that is not in the ownership of ACS AEM Commons is untouched, does not get overwritten or removed.

Actual Behavior

ACS AEM Commons overwrites at least the following nodes, including all their properties: image

This means that any property that is set on /apps/dam, /apps/dam/gui, /apps/dam/gui/content, ... is overwritten.

Steps to Reproduce

Install the content package, then check the /apps folder for example. Any properties that were previously set are now overwritten.

henrykuijpers commented 12 months ago

Seems to have been caused in https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2804 With the switch to Filevault in https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2043

kwin commented 12 months ago

@henrykuijpers Which properties do you set on those nodes that get lost? The problem really is that the package needs to make sure that the ancestor nodes for its overlays are created (if not yet there) with the right primary type and mixin (https://jackrabbit.apache.org/filevault/filter.html#Uncovered_ancestor_nodes). That is only possible by overwriting the full node unfortunately in older FileVault versions. I don't know of any other means, how one can otherwise enforce the right ancestor node types (compare with discussion in https://issues.apache.org/jira/browse/JCRVLT-403)