search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
454 stars 600 forks source link

Provide precompiled scripts for AEM 6.5.21 #3403

Open henrykuijpers opened 2 months ago

henrykuijpers commented 2 months ago

Required Information

It would be nice to have precompiled scripts for ACS AEM Commons. :) This way, with on-premise AEM, we could leverage faster execution times and no more delays due to waiting for scripts to compile ad-hoc.

kwin commented 2 months ago

AFAIK this is only supported in AEMaaCS: https://github.com/adobe/aem-core-wcm-components/issues/1706 which makes this more difficult to implement in ACS AEM Commons (which still supports AEM 6.5)

henrykuijpers commented 2 months ago

It also works in AEM 6.5 SP21, because of all the dependency bumps, including the servlets resolver bump. :)

I precompiled all the scripts in our projects. Precompiled all the scripts in AEM. And now ACS AEM Commons (and wcm.io libraries) are the only ones that have their scripts still go through adhoc compilation.

kwin commented 2 months ago

Without having an official confirmation from Adobe side on this, I would be a bit reluctant to do this. @henrykuijpers Do you have pointers since which SP this works? We claim to be compatible with 6.5.10+ (https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/b9095ac434eb96d69135ffd2da4b2d1c3d2a2bcd/pom.xml#L87)

henrykuijpers commented 2 months ago

I agree on that. Hopefully this documentation will be there soon. :)

On the other hand, it shouldn't hurt for AEMaaCS users, as they can already leverage these precompiled scripts.

henrykuijpers commented 2 months ago

It works since SP21. That service pack bumps a whole lot of dependencies in AEM. Including the servlets resolver bundle, which contains the precompiled scripts support.

kwin commented 2 months ago

Currently the uber-jar for 6.5.21 generates import-package version ranges not resolvable in the newest AEMaaCS (https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/3406#issuecomment-2271817631).