Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
456 stars 603 forks source link

XSS vulnerability in the page compare feature on the Author Env #3432

Open kashifsyedqd opened 2 months ago

kashifsyedqd commented 2 months ago

Required Information

Vulnerability reported through Security Scan on AEM Cloud Author env:

BLS T001 Medium xxs bug to be remediated: ADOBE AEM Cloud Reflected Cross-Site Scripting (XSS) The /apps/acs-commons/content/page-compare.html endpoint in the AEM author application is vulnerable to Reflected XSS via the a and b GET parameters. User input submitted via these parameters is not validated or sanitized. As a result, arbitrary JavaScript code is executed in the victim's browser. This vulnerability was reported in the previous AEM BAA for 2023, as Finding [T001] and has been assigned CVE-2022-28820. Since that report, the CVE in question was remediated within the AEM ACS Commons project in version 5.2.0. However, according to recent issues on the AEM ACS Commons github project[2], this same vulnerability has been reintroduced into the project, or previous fixes were insufficient. This vulnerability exists due to a lack of adherence to the following SCF IDs: TDA-06 TDA-06.5 TDA-09 TDA-09.2 TDA-09.3 TDA-09.4 TDA-09.5 TDA-09.7 TDA-18 WEB-09 https://github.com/Adobe-Consulting-Services/acs-aem-commons/releases ASC Commons latest version 6.6.2

Please describe briefly the expected behavior, i.e. when I do X, Y should happen.

Questions:

Is it possible to fix this issue soon? If not could you please suggest if we can disable the page compare feature in our author env?

kwin commented 2 months ago

Can you come up with a PR containing a fix?

kashifsyedqd commented 2 months ago

@kwin I would have loved to but currently my plate is full!