search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
454 stars 603 forks source link

Granite include top level fixes #3457

Closed niekraaijmakers closed 3 weeks ago

niekraaijmakers commented 1 month ago

Currently, properties on the top level of the snippet are ignored and not included. This forces you to put them on the include level.

With this PR, the snippet top level values count, unless overridden by specifying it on the include level. Also, the default resourceType is now set to the container resource type.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 55.69%. Comparing base (ef4f406) to head (4361b7c). Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...mpl/include/NamespaceDecoratedValueMapBuilder.java 21.42% 10 Missing and 1 partial :warning:
...ponents/impl/include/NamespaceResourceWrapper.java 60.00% 2 Missing :warning:
...ude/NamespacedTransformedResourceProviderImpl.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3457 +/- ## ============================================ + Coverage 55.54% 55.69% +0.14% - Complexity 5582 5601 +19 ============================================ Files 728 728 Lines 29775 29856 +81 Branches 3884 3901 +17 ============================================ + Hits 16540 16627 +87 + Misses 11684 11670 -14 - Partials 1551 1559 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.