search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
454 stars 600 forks source link

AEM Author Loading Blank #3463

Open YegorKozlov opened 5 days ago

YegorKozlov commented 5 days ago

Required Information

AEM Author is loading Blank with the latest ACS 6.9.0

image

@niekraaijmakers IncludeDecoratorFilterImpl seems to be the culprit. The filter is missing the else block

        if(typeCheckFn.test(RESOURCE_TYPE)){
           .... 
        }else if(resourceTypesIgnoreChildren.stream().anyMatch(typeCheckFn)){
           .... 
        } else {
           // the 'else' clause  is missing in 6.9.0
            chain.doFilter(servletRequest, servletResponse);
        }
niekraaijmakers commented 5 days ago

Thanks for spotting this @YegorKozlov . I don't know how I missed this. PR opened, https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/3464 .

niekraaijmakers commented 5 days ago

@davidjgonzalez can we merge this and re-release? sorry for the bother

jdavenport-vervio commented 2 days ago

This issue is also caused by a syntax error in one of the errorpagehandler JSP files, I've raised a PR to fix: https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/3466

FYI @davidjgonzalez @niekraaijmakers