search

Adobe-Consulting-Services / acs-aem-commons

http://adobe-consulting-services.github.io/acs-aem-commons/
Apache License 2.0
453 stars 599 forks source link

IconPicker in Touch UI - Problem with the classValuePrefix #651

Closed jfgrenier-inm closed 7 years ago

jfgrenier-inm commented 8 years ago

Hi

There is a problem with the render of the Selcted Icon. this.settings.classValuePrefix is undefined and there is no space between the "undefined prefix" and the "fa" class.

So the class is generated like this : <i class="undefinedfa fa-bluetooth-b"></i> instead of <i class="fa fa-bluetooth-b"></i>

File : acs-aem-commons/content/src/main/content/jcr_root/apps/acs-commons/authoring/vendor/jquery.fonticonpicker/jquery.fonticonpicker.js

Line : 695

viveksachdeva commented 8 years ago

@jfgrenier-inm : Could you add steps to reproduce this issue? Thanks!!

viveksachdeva commented 7 years ago

@jfgrenier-inm : Here is the PR that I have created for this issue.. Mind taking a look? Thanks!! https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/811