Adobe-Consulting-Services / acs-aem-samples

AEM Code Samples repository
http://adobe-consulting-services.github.io/acs-aem-samples/
Apache License 2.0
206 stars 196 forks source link

ContentBuilder for Replication Serializer #44

Open dlh3 opened 8 years ago

dlh3 commented 8 years ago

I nominate Matthias Wermund's (Acquity Group part of Accenture) ContentBuilder implementation to be included as a sample Replication Serializer: https://github.com/mwmd/circuit14-aem-replication/tree/master/bundle/src/main/java/com/wmd/serialization/impl

Related SlideShare deck with other potential samples: http://www.slideshare.net/mwmd/adobe-experience-manager-replication-deep-dive

davidjgonzalez commented 8 years ago

@dlh3 any reason why the Builder couldnt use https://sling.apache.org/apidocs/sling6/org/apache/sling/commons/json/jcr/JsonItemWriter.html ? seems more straight forward that making fake request/response objs?

That being said, having a suite of commonly used replication extensions would be nice.

dlh3 commented 8 years ago

No reason that I'm aware of. Perhaps @mwmd could comment, as it was his code, not mine.

davidjgonzalez commented 8 years ago

@dlh3 I think if we pull this we should update the code to use the Json writer API which makes its reasonably different from the current Impl. May be easier to just write from scratch?

dlh3 commented 8 years ago

Reimplemented with the JSON Writer API and created PR #45.