Adobe-Consulting-Services / acs-aem-tools

http://adobe-consulting-services.github.io/acs-aem-tools/
120 stars 97 forks source link

Ace JS does not load correctly when versioned client libs are enabled #25

Open justinedelson opened 10 years ago

justinedelson commented 10 years ago

This is an interesting edge case. When versioned client libs (http://adobe-consulting-services.github.io/acs-aem-commons/features/versioned-clientlibs.html) are enabled, the JavaScript for the Ace editor in AEM Fiddle tries to load modules from /etc/clientlibs/acs-tools instead of /etc/clientlibs/acs-tools/aceeditor.

davidjgonzalez commented 10 years ago

Erm - you mean:

tries to load modules from /etc/clientlibs/acs-tools instead of /etc/clientlibs/acs-tools/aceeditor right? The ace folder is under ../aceeditor. IIRC it expects the modules to be siblings to it (thus the wonky aceeditor/ace[cq:ClientLibraryFolder] structure).

justinedelson commented 10 years ago

yes... my bad for not taking a screenshot before disabling versioned client libs. and then I got sucked into other problems...

http://localhost:4502/etc/acs-tools/mode-html.js is an example of a URL which is requested. the URL for ace.js is http://localhost:4502/etc/clientlibs/acs-tools/aceeditor/ace.f6e623a1537ebd4d0e028b680e05542e.js

davidjgonzalez commented 10 years ago

I'll see if I can take a look tomorrow. That is really bizarre. If it's something in ace, we can add a flag to disabled versioning in the transformer. Might be with having that anyhow.

justinedelson commented 10 years ago

It's actually easy to workaround by specifing paths=[/content] on the rewriter config. But it'd be ideal to not have to remember to do that :)