search

Adobe-Consulting-Services / acs-aem-tools

http://adobe-consulting-services.github.io/acs-aem-tools/
120 stars 97 forks source link

Angularjs does not load when HTML Library manager minification enabled #40

Closed davidjgonzalez closed 9 years ago

davidjgonzalez commented 10 years ago

Aem 5.6.1 - observed /etc/clientlibs/acs-commons/angularjs.min.js 404s - disabling minification in HTML library manager resolves the issue.

justinedelson commented 10 years ago

Any error in the log? Usually this happens when the compressor can't compile the js

davidjgonzalez commented 10 years ago

Was on some one else's computer and I found/fixed as I was out the door. Stuck on amtrak in the cafe car now. Logged as issue so I don't forget to look into later.

justinedelson commented 10 years ago

Maybe related to - https://github.com/yui/yuicompressor/issues/47 ?

davidjgonzalez commented 10 years ago

@justinedelson Looks like this is the culprit. Including the pre-minified angular.min.js in the client lib seems to resolve the compilation issue, but there are still some other issues going on; QE works but Fiddle still doesn't. Also, it looks like HTML Library minification breaks ace editor just like version clientlibs does (can't remember if you noticed it on the versioning or both).

sbmadhav commented 9 years ago

The html still wont load. Too many script errors.

davidjgonzalez commented 9 years ago

@sbmadhav what version of AEM and ACS Tools, and what specific Feature(s) do you see this on?

sbmadhav commented 9 years ago

@davidjgonzalez : This issue is resolved. It was'nt to do with the angular.min.js.

davidjgonzalez commented 9 years ago

Can you share the cause of the issue and resolution?

sbmadhav commented 9 years ago

@davidjgonzalez : the issue was with use of incorrect import which was overseen due to large codebase. Nothing to do with Angular or AEM.

davidjgonzalez commented 9 years ago

Thanks for keeping us posted!

Tewari1005 commented 7 years ago

HI All,

I am facing same issue that during minification of angular js using AEM OTB functionality we are receiving 34 syntax error in error.log file. We are using AEM 6.1 with SP2 and angular version is 1.6.1. Any one who have minified this angular JS version for AEM 6.1 ,please share it over mail(tewari.b34991@gmail.com) or here . This will help us a lot

Shashi-Bhushan commented 7 years ago

@Tewari1005 Firstly you need to check on your console, for which clientlibs there is minification error. Then, you need to check individually what could be the error in individual JS files (of the clientlib where you got the error). I upload my JS files individually on http://yui.2clics.net/ and it gives me error while compressing using YUI compression.