Adobe-Consulting-Services / adobe-consulting-services.github.io

Adobe Consulting Services (AEM)
http://adobe-consulting-services.github.io/
40 stars 70 forks source link

Add ACS AEM Commons to your AEM Maven project - Documentation #271

Closed DasAnk closed 2 months ago

DasAnk commented 3 months ago

Required Information

Expected Behavior

While referring to https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html for adding ACS AEM Commons to my project, I felt the documentation needs to be more precise for AEM as a Cloud Service.

Actual Behavior

The section for AEM as a Cloud Service says "All information of AEM 6.5 above applies, but instead of using the acs-aem-commons-all, a specific classifier for cloud is foreseen.". - This seems incorrect because we don't remove artifactId cs-aem-commons-all. May we be more specific for AEM as a Cloud Service? I was finally able to make it work for the latest version (6.6.0) by adding the following dependency in the all project’s pom.xml file which installed ui.apps, ui.content and bundles. Which means for AEM as a Cloud Service, we need not add anything in the core/pom.xml for Java API. For the cloud classifier, version is also needed for fetching the correct artifact. This is again not clear from the document. `

com.adobe.acs
        <artifactId>acs-aem-commons-all</artifactId>
        <version>6.6.0</version>
        <type>zip</type>
        <classifier>cloud</classifier>

`

Steps to Reproduce

Request for the documentation update

Links

https://adobe-consulting-services.github.io/acs-aem-commons/pages/maven.html

kwin commented 3 months ago

Please check out https://github.com/Adobe-Consulting-Services/adobe-consulting-services.github.io/pull/265/files

DasAnk commented 3 months ago

Thanks @kwin for a quick turnaround.

kwin commented 2 months ago

Fixed in https://github.com/Adobe-Consulting-Services/adobe-consulting-services.github.io/commit/f021de75c835ae6d5b1ecfdd17fec794b3072af9.