Adobe-Marketing-Cloud / aem-guides-wknd-events

Step by Step guide to creating a Single Page Application to use with AEM
48 stars 34 forks source link

[React] Chapter 1 is not working in IE 11 #57

Closed epsilon-prasad closed 5 years ago

epsilon-prasad commented 5 years ago

Local Environment Before filing an issue, verify that the prerequisite tools/software are installed:

Describe the issue Chapter-1 Editable components is not working in IE 11. But its working in chrome, firefox and Edge, In IE 11 i am getting blank screen with console error Object doesn't support property or method 'endsWith'

import 'es6-shim'; import 'react-app-polyfill/ie9'; import 'core-js/features/array/find'; import 'core-js/features/array/includes'; import 'core-js/features/number/is-nan';

by import this packages in the src/index.js the above error is resolved but i am still get a blank screen in IE without console error.

Where in the tutorial are you experiencing an issue?

In Chapter 1 in Step #6 console

godanny86 commented 5 years ago

Hi @epsilon-prasad can you reproduce this issue when generating a new project using the SPA archetype? https://github.com/adobe/aem-spa-project-archetype.

As this project is based on the create-react-app I don't think IE11 is supported by default. You may need to add something like react-app-polyfill to your project. More info can be found here

epsilon-prasad commented 5 years ago

Hi @godanny86, yes i am able to reproduce the issue.

i have updated the polyfill also Adding import 'react-app-polyfill/ie11'; import 'core-js'; in App/index.js. still i am getting blank screen in IE 11 only.

godanny86 commented 5 years ago

would you mind filing an issue on the SPA Project archetype [0]? I think we need to get the recommended approach for IE 11 support from product engineering

cc. @pfauchere

[0] -https://github.com/adobe/aem-spa-project-archetype/issues