search

Adobe-Marketing-Cloud / aem-sample-we-retail

🚫 We.Retail has been archived, see instead the WKND Guide:
https://github.com/adobe/aem-guides-wknd
Apache License 2.0
123 stars 141 forks source link

Remove RAT check for end user #127

Closed sammykumar closed 7 years ago

sammykumar commented 7 years ago

Building We-Retail on the master branch fails due to unapproved licenses found during rat check

it.launcher/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst it.launcher/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst it.launcher/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/createdFiles.lst it.launcher/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/inputFiles.lst it.launcher/we.retail.it.launcher.iml it.tests/target/classes/META-INF/MANIFEST.MF it.tests/we.retail.it.tests.iml

As the end user, the only way to bypass this is to run with -Drat.skip

I'd like to help fix this but, I'm not sure what the best way about this is. Should I submit a PR removing rat check complete or exclude the files that are being flagged by rat check?

raducotescu commented 7 years ago

@sammykumar, there's no it.launcher module on the master branch for quite some time: 86c4f15. I guess your clone still has that folder for some reason. Please delete it and try to rebuild.

sammykumar commented 7 years ago

Thanks @raducotescu. Strange that I still had it.