search

Adobe-Marketing-Cloud / aem-sample-we-retail

🚫 We.Retail has been archived, see instead the WKND Guide:
https://github.com/adobe/aem-guides-wknd
Apache License 2.0
123 stars 141 forks source link

Thread Safety issue in CountriesFormOptionsDataSource #148

Closed justinedelson closed 6 years ago

justinedelson commented 6 years ago

The class CountriesFormOptionsDataSource uses an instance variable to store the I18n object. At scale, this will result in the wrong resource bundle being used single multiple concurrent invocations of this servlet will overwrite this object. Instead of an instance variable, it should be a local variable passed method to method.

bpauli commented 6 years ago

@justinedelson Thank you for the hands up. We will fix this issue in the upcoming release. (4237823)

bpauli commented 6 years ago

fixed in https://github.com/Adobe-Marketing-Cloud/aem-sample-we-retail/commit/c509c0c68f8941fad8d69eff237ab6b9b51fbdd3