search

Adobe-Marketing-Cloud / aem-sample-we-retail

🚫 We.Retail has been archived, see instead the WKND Guide:
https://github.com/adobe/aem-guides-wknd
Apache License 2.0
123 stars 141 forks source link

We.Retail pages do not load correctly inside the Target Visual Experience Composer (VEC) #151

Closed ittaibaratz closed 5 years ago

ittaibaratz commented 6 years ago

When loading a we.retail webpage inside Adobe Target Visual Experience Composer (VEC), the page does not render correctly as shown below:

image

The page footer is located right below the header, instead of the bottom of the page. This is because the we.retail expects the body element to have relative position, however inside the VEC , Adobe Target overrides the body position and makes it static:

image

I was able to solve this on my local AEM instance by removing the bottom value from .footer .we-Footer (https://github.com/Adobe-Marketing-Cloud/aem-sample-we-retail/blob/master/ui.apps/src/main/content/jcr_root/apps/weretail/components/structure/footer/clientlibs/less/footer.less)

I don't think the bottom value is necessary as the footer will flow to the bottom without it. Please check. This fix is required for demoing We.Retail content inside Adobe Target.

cc @keepthebyte , @martinbuergi , @gabrielwalt @gknobloch @bpauli

gabrielwalt commented 6 years ago

I agree, we could have the footer positioned statically.

jckautzmann commented 5 years ago

(CQ-4263821)

jckautzmann commented 5 years ago

This issue has been fixed and will be available with the 4.0.0 release of We.Retail