search

Adobe-Marketing-Cloud / aem-translation-framework-bootstrap-connector

Bootstrap Translation connector using the Adobe Experience Manager (AEM) Translation Vendor API
https://helpx.adobe.com/experience-manager/using/bootstrap.html
Other
22 stars 21 forks source link

getCloudConfigObjectFromPath deprecated in 6.4x #4

Open florianmesserli opened 5 years ago

florianmesserli commented 5 years ago

Hi, In 6.4x, the method getCloudConfigObjectFromPath(Class,String) is deprecated, replaced by Object getCloudConfigObjectFromPath(Resource, Class, String)

If we use uber-jar 6.4.x, the framework will not work. How can we add the "resource" here?

https://github.com/Adobe-Marketing-Cloud/aem-translation-framework-bootstrap-connector/blob/aem640-crosslang/core/src/main/java/com/adobe/granite/translation/connector/bootstrap/core/impl/BootstrapTranslationServiceFactoryImpl.java (line 87)

@Override
    public TranslationService createTranslationService(TranslationMethod translationMethod, String cloudConfigPath)
            throws TranslationException {
        log.trace("BootstrapTranslationServiceFactoryImpl.createTranslationService");

        BootstrapTranslationCloudConfig bootstrapCloudConfg = (BootstrapTranslationCloudConfig) cloudConfigUtil
                .getCloudConfigObjectFromPath(BootstrapTranslationCloudConfig.class, cloudConfigPath);

        String dummyConfigId = "";
        String dummyServerUrl = "";
        String previewPath = "";

https://helpx.adobe.com/experience-manager/6-4/sites/developing/using/reference-materials/diff-previous/changes/com.adobe.granite.translation.core.TranslationCloudConfigUtil.html https://helpx.adobe.com/experience-manager/6-4/sites/developing/using/reference-materials/javadoc/com/adobe/granite/translation/core/TranslationCloudConfigUtil.html#getCloudConfigObjectFromPath-org.apache.sling.api.resource.Resource-java.lang.Class-java.lang.String-

snowakXtm commented 5 years ago

bump

SKumarKola commented 5 years ago

Hi, Any update on this- please.?

ankursial commented 5 years ago

Hi,

We have not adapted our SPIs and bootstrap connector w.r.t this change. I have added an issue in our backlog for the same.

NSzolnoki commented 3 years ago

Hi, is there any update, can I ask for the working code snippet for getting the cloud config?