search

Adobe-Marketing-Cloud / aep-sdks-documentation

Documentation repository for the Adobe Experience Platform Mobile SDKs
MIT License
26 stars 106 forks source link

iam beta docs #714

Closed sbenedicadb closed 2 years ago

sbenedicadb commented 2 years ago

thank you, @calebk1 , for the review!

  1. just removing .DS_Store (it's also in .gitignore, but had previously been checked in so was still getting picked up in updates)
  2. there's only a small amount of javascript in the doc, and i'm not able to follow the request you're asking for. can you please be more explicit for my simpleton brain? :)
  3. 👍 what size header, h3?
  4. @rymorale will be adding docs for android/java side of things. to that end, i will update the target branch to be a new staging branch so we can get all beta doc changes in one place prior to merging into master.
calebk1 commented 2 years ago

With regards to the following comments:

  1. Sweet! Just wanted to make sure, but removing it should be a-okay.
  2. Oh! There some instances where it was written as javascript or Javascript, but, if I recall correctly, it's preferred to style it as JavaScript.
  3. I'd just leave it as a sentence instead. I don't think it really needs any heading, since it seems like it's just a one step process, nor is it really a header with any subsequent content.
  4. Got it! No worries then! I was just worried some wires got crossed in the process.
sbenedicadb commented 2 years ago

@calebk1 updated! let me know if there's anything else.

sbenedicadb commented 2 years ago

thank you @swarna04 - updates have been made

sbenedicadb commented 2 years ago

@calebk1 @swarna04 we can merge this in once you all give final approval