search

Adobe-Marketing-Cloud / aep-sdks-documentation

Documentation repository for the Adobe Experience Platform Mobile SDKs
MIT License
26 stars 106 forks source link

Fix NetworkServiceOverrider docs for Android #749

Closed addb closed 2 years ago

emdobrin commented 2 years ago

@addb @yangyansong-adbe wondering if we can add a new example to use the new Service Provider network service overwrite. We can still keep this one, but also add the new one on top, thoughts?

addb commented 2 years ago

@addb @yangyansong-adbe wondering if we can add a new example to use the new Service Provider network service overwrite. We can still keep this one, but also add the new one on top, thoughts?

Do you mean we should have sample using one of the network libraries? I am not sure about that. I think we can specify steps more clearly if needed. @yangyansong-adbe what do you think about this?

Can we merge the PR, so we have newer changes needed to implement this feature and have a thread to discuss this internally?

yangyansong-adbe commented 2 years ago

@emdobrin yes, I think we should add a new section for the Service Provider solution. @addb Core will deprecate SampleHTTPConnectionPerformer in the future. Like the Swift SDK, Android Core also exposes a public ServiceProvider.setNetworkService method that lets customers override the Network Service. https://git.corp.adobe.com/dms-mobile/bourbon-platform-android-core/blob/8615f7fb817c168ba47ef2c8b1844f16ff1709a6/code/android-core-library/src/phone/java/com/adobe/marketing/mobile/services/ServiceProvider.java#L139 We can merge this PR and update the public docs when we decide to deprecate the old network service override option.

cc @praveek

emdobrin commented 2 years ago

@yangyansong-adbe sounds good, can you please create a task to document the ServiceProvider.setNetworkService option?