search

Adobe-Marketing-Cloud / analytics-java-library

A Java client library for Analytics APIs
Apache License 2.0
15 stars 16 forks source link

Multiple quality improvements #13

Closed m-ezzat closed 6 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules pmd:AppendCharacterWithChar - Append Character With Char pmd:ImmutableField - Immutable Field squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=pmd:AppendCharacterWithChar https://dev.eclipse.org/sonar/coding_rules#q=pmd:ImmutableField https://dev.eclipse.org/sonar/coding_rules#q=squid:SwitchLastCaseIsDefaultCheck https://dev.eclipse.org/sonar/coding_rules#q=squid:UselessParenthesesCheck

Please let me know if you have any questions.

M-Ezzat

m-ezzat commented 8 years ago

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

trekawek commented 6 years ago

Merged in 92724f6.