[Roku] unused variables

[ahwayakchih]

Hi,

Roku started warning about unused variables that should either be removed or prefixed with underscore. Here's a list of warnings regarding adbmobile we get in the project:

BRIGHTSCRIPT: WARNING: unused variable 'segments' in function '$anon_a61' in pkg:/components/libs/adbmobile/adbmobile.brs(1023)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_a9c' in pkg:/components/libs/adbmobile/adbmobile.brs(1721)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_a9d' in pkg:/components/libs/adbmobile/adbmobile.brs(1724)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_a9e' in pkg:/components/libs/adbmobile/adbmobile.brs(1727)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_a9f' in pkg:/components/libs/adbmobile/adbmobile.brs(1730)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_aa0' in pkg:/components/libs/adbmobile/adbmobile.brs(1733)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_aa1' in pkg:/components/libs/adbmobile/adbmobile.brs(1736)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_aa2' in pkg:/components/libs/adbmobile/adbmobile.brs(1739)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_aa3' in pkg:/components/libs/adbmobile/adbmobile.brs(1742)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_aa4' in pkg:/components/libs/adbmobile/adbmobile.brs(1745)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_aae' in pkg:/components/libs/adbmobile/adbmobile.brs(1818)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ab3' in pkg:/components/libs/adbmobile/adbmobile.brs(1886)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ab7' in pkg:/components/libs/adbmobile/adbmobile.brs(1938)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ab9' in pkg:/components/libs/adbmobile/adbmobile.brs(1949)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_abb' in pkg:/components/libs/adbmobile/adbmobile.brs(1979)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_abc' in pkg:/components/libs/adbmobile/adbmobile.brs(1988)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_abe' in pkg:/components/libs/adbmobile/adbmobile.brs(2011)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_abf' in pkg:/components/libs/adbmobile/adbmobile.brs(2018)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac0' in pkg:/components/libs/adbmobile/adbmobile.brs(2026)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac1' in pkg:/components/libs/adbmobile/adbmobile.brs(2031)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac2' in pkg:/components/libs/adbmobile/adbmobile.brs(2035)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac3' in pkg:/components/libs/adbmobile/adbmobile.brs(2039)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac4' in pkg:/components/libs/adbmobile/adbmobile.brs(2045)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac5' in pkg:/components/libs/adbmobile/adbmobile.brs(2049)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac6' in pkg:/components/libs/adbmobile/adbmobile.brs(2055)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac7' in pkg:/components/libs/adbmobile/adbmobile.brs(2059)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ac9' in pkg:/components/libs/adbmobile/adbmobile.brs(2075)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_acb' in pkg:/components/libs/adbmobile/adbmobile.brs(2086)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_ace' in pkg:/components/libs/adbmobile/adbmobile.brs(2111)
BRIGHTSCRIPT: WARNING: unused variable 'recontext' in function '$anon_acf' in pkg:/components/libs/adbmobile/adbmobile.brs(2118)
BRIGHTSCRIPT: WARNING: unused variable 'singlequote' in function '$anon_b6f' in pkg:/components/libs/adbmobile/adbmobile.brs(4213)
BRIGHTSCRIPT: WARNING: unused variable 'val' in function '$anon_b70' in pkg:/components/libs/adbmobile/adbmobile.brs(4242)
BRIGHTSCRIPT: WARNING: unused variable 'combinedvarkeys' in function '$anon_b70' in pkg:/components/libs/adbmobile/adbmobile.brs(4242)
BRIGHTSCRIPT: WARNING: unused variable 'expectedvalue' in function '$anon_bae' in pkg:/components/libs/adbmobile/adbmobile.brs(4999)
BRIGHTSCRIPT: WARNING: unused variable 'val' in function '$anon_bb2' in pkg:/components/libs/adbmobile/adbmobile.brs(5048)
BRIGHTSCRIPT: WARNING: unused variable 'messagejson' in function '$anon_bb6' in pkg:/components/libs/adbmobile/adbmobile.brs(5119)
BRIGHTSCRIPT: WARNING: unused variable 'vars' in function '$anon_bb7' in pkg:/components/libs/adbmobile/adbmobile.brs(5121)
BRIGHTSCRIPT: WARNING: unused variable 'cdata' in function '$anon_bb7' in pkg:/components/libs/adbmobile/adbmobile.brs(5121)
BRIGHTSCRIPT: WARNING: unused variable 'combinedvars' in function '$anon_bb8' in pkg:/components/libs/adbmobile/adbmobile.brs(5123)
Displayed 40 of 40 warnings

Total numbers are one higher because first warning is about Roku's own library ;).

Is there any plan to update SDK for Roku?

Regards

[addb]

Hi @ahwayakchih,

Thanks for bringing this to our attention. We will evaluate this issue and update you. Just to understand the severity, this isn't blocking your channel from publishing right?

Thanks, Arjun

[ahwayakchih]

Hi @addb,

Thanks for quick answer :).

No, we're not blocked AFAIK (but channel was not published yet, we'll see :). I can't find the link, but there was some mention about blocking in near future.

In release notes https://developer.roku.com/en-gb/docs/developer-program/release-notes/roku-os-release-notes.md#roku-os-110, "Tagging of unused variables" includes this:

This enables developers to avoid compilation errors when the unused variable has a valid purpose.

So they call them "errors", even though (at least for now) they are warnings.

Regards

[addb]

We have this in our backlog. Will update here once we make a release with the changes.