Remote Offers not working with later versions of AT.js (>0.94)

Adobe-Marketing-Cloud / target-atjs-extensions

Adobe Target extensions to at.js to support Single Page Application implementations

56 stars 28 forks source link

Remote Offers not working with later versions of AT.js (>0.94) #26

Closed ittaibaratz closed 7 years ago

ittaibaratz commented 7 years ago

Hi there,

The remote offers plugin does not work properly with newer versions of AT.js - Offers are not getting deployed on the page.

I tracked down the issue to the structure of the JSON offer created by the extension. I was able to fix it locally by changing the applyOffers call as follows:

I am not clear on the gulp build process and so I did not create a pull request - Please let me know if you need more information.

artur-ciocanu commented 7 years ago

@XDex when you have a chance could you please take a look.

dwright-adobe commented 7 years ago

@XDex , i see that @IttaiB 's fix is necessary to get 0.3.0 working with at.js 1.1.0. Can you also look at legacy browser support? 0.3.0 references that it uses MO, but haven't the polyfills been removed in the latest at.js versions?

XDex commented 7 years ago

@ittaibaratz Fixed in #33 @dwright-adobe As the polyfills have been removed in the latest at.js versions, MO and WeakMap polyfills are still bundled together with the extension..