search

Adobe-Marketing-Cloud / target-atjs-extensions

Adobe Target extensions to at.js to support Single Page Application implementations
56 stars 29 forks source link

UI-Router Extension Not Working #31

Open coatsnmore opened 6 years ago

coatsnmore commented 6 years ago

We are seeing issues with the ui-router extension. It breaks on the following line for each state in the ui-router extension#initializeModule method:

var offerData = $state.$current.locals.globals.offerData;

With the following error: image

With the following dependencies:

"dependencies": {
    "@uirouter/angularjs": "^1.0.5",
    "angular": "^1.6.2",
    "bootstrap": "^4.0.0-alpha.6",
    "lodash": "^4.17.4"
  },

I am assuming this is a version incompatibility, but don't know enough to offer a solution.

coatsnmore commented 6 years ago

Reproduced with ui-router extension 0.2.1.

XDex commented 6 years ago

@coatsnmore I've taken a quick look, the problem is that there've been a number of breaking changes in ui-router 1.x release, compared to 0.2.x one, which is supported by the existing ui-router extension. We'll need to reimplement the extension to support the latest ui-router. I'll try to find some time to do it in the next few weeks..

shawncreed commented 6 years ago

@XDex Is there any chance you've been able to update this? This issue is a blocker for me on one of my client projects. Thank you!

XDex commented 6 years ago

@shawncreed Sorry, we've been quite busy lately, I'll try to take a look once I have some spare time in the following weeks.. Btw, PRs are always welcome :)

XDex commented 6 years ago

@coatsnmore @shawncreed Just fixed this in #38, please try out the new ui-router extension and let me know if you run into any issues..