search

AdobeDocs / app-builder

Documentation for Adobe App Builder
https://developer.adobe.com/app-builder/docs/overview/
Apache License 2.0
34 stars 61 forks source link

Update Getting Started optional tools section with latest Node14 Docker images #131

Open meryllblanchet opened 3 years ago

meryllblanchet commented 3 years ago

https://github.com/AdobeDocs/project-firefly/blob/main/src/pages/getting_started/index.md

1) Node10 and Node12 images are mentioned, but Node14 images should be preferably used. 2) The documentation could be clearer about when to download the images manually (e.g. on slow connections).

shazron commented 3 years ago

adobeapiplatform/adobe-action-nodejs-v10 is at 3.0.28 now adobeapiplatform/adobe-action-nodejs-v12 is at 3.0.28 now adobeapiplatform/adobe-action-nodejs-v14 is at 3.0.28 now

shazron commented 3 years ago

Related: https://github.com/adobe/aio-cli-plugin-app/pull/481

elagun commented 3 years ago

It should also be noted in the Optional Tools section that these Docker image need not be pulled manually. They will be downloaded and run automatically by the CLI when running aio app:run --local.

Especially the part "The following commands must be executed to install the required Docker images" should be removed because it's not correct. In fact the CLI will most probably download a different version and not use the Docker image that you downloaded manually at all. For example, I manually downloaded v14:3.0.28 and then running the local development the CLI ignored this image and downloaded and ran v14:3.0.26