AdobeDocs / cc-everywhere

Documentation site for Adobe Express Embed SDK
https://developer.adobe.com/express/embed-sdk/docs/guides/
Apache License 2.0
11 stars 35 forks source link

Bump npm dependencies to non-conflicting spectrum versions #93

Closed Brandutchmen closed 1 year ago

Brandutchmen commented 1 year ago

NPM install dependency conflict

NPM install error:

# npm resolution error report

While resolving: undefined@undefined
Found: @spectrum-css/vars@6.1.1
node_modules/@spectrum-css/vars
  @spectrum-css/vars@"^6.1.1" from the root project

Could not resolve dependency:
peer @spectrum-css/vars@"^8.0.0" from @spectrum-css/button@6.0.21
node_modules/@spectrum-css/button
  @spectrum-css/button@"^6.0.1" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

We can fix this by updating to the latest versions of spectrum-css

Brandutchmen commented 1 year ago

cc: @amandahuarng

amandahuarng commented 1 year ago

the newer versions actually aren't super stable yet (checked with Spectrum team). I have a new PR ready with the right packages listed so I'll defer to that one 👍 Thanks for the catch regardless