Variable type Not required - Githubissues

AdobeDocs / commerce-php

Source of the Commerce PHP Extensions guide

https://developer.adobe.com/commerce/php/

Other

9 stars 140 forks source link

Variable type Not required #241

Open pawan opened 9 months ago

pawan commented 9 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Which topic?

https://developer.adobe.com/commerce/php/tutorials/frontend/custom-checkout/add-shipping-carrier/

What's wrong with the content?

In the guide for Add a custom shipping carrier section 3 i.e. https://developer.adobe.com/commerce/php/tutorials/frontend/custom-checkout/add-shipping-carrier/#step-3-create-the-carrier-model at line number 20 and 22, variables $_code and $_isFixed type declaration not required and if we add variable type, Will give fatal error like:

Fatal Error : Type of Vendor\CustomShipping\Model\Carrier\Customshipping:$_code must not be defined

What changes do you propose?

Not required variable type declaration as it will be taken care by base class.

Anything else that can help to cover this?

No response

pawan commented 9 months ago

@magento-docs @magento I am working on this