AdobeDocs / experience-manager-core-components.en

This is the repository for Adobe Experience Manager Core Components documentation. Your contributions to the documentation are welcome.
https://experienceleague.adobe.com/en/docs/experience-manager-core-components/using/introduction
MIT License
8 stars 24 forks source link

Archetype should handle hyphens or document should call out the constraint #31

Closed himanshu-pathak closed 2 years ago

himanshu-pathak commented 2 years ago

Issue in ./help/developing/archetype/overview.md

This issue is applicable to both the links below

If you specify the groupId with a '-' in it, the projects gets created but the code fails in the build. It would be good if we handle this. Some options

  1. Project creation fails fast with the error that the group id is invalid.
  2. The hyphens in groupId field are replaced with . or _ or some other valid characters.
  3. documentation calls out the WARNING explicitly.
bohnertchris commented 2 years ago

Hello @himanshu-pathak and thank you for the suggestion for our documentation. We will review to update the docs. If you wish for a change to the code, please consider creating a PR with your suggestion against the Core Components repository.

https://github.com/adobe/aem-core-wcm-components

bohnertchris commented 2 years ago

@adobe export issue to Jira project CQDOC

github-jira-sync-bot commented 2 years ago

:white_check_mark: Jira issue CQDOC-18946 is successfully created for this GitHub issue.

bohnertchris commented 2 years ago

We expanded our documentation of the groupId parameter with commit edfe50e in our docs and commit 67ad97d of the archetype repository. Thank you for reporting this.