AdolfVonKleist / Phonetisaurus

Phonetisaurus G2P
BSD 3-Clause "New" or "Revised" License
453 stars 122 forks source link

Fixes to make the project work with OpenFST 1.8.3 #89

Open danijel3 opened 5 days ago

danijel3 commented 5 days ago

Most of the world has moved to version 1.8.3 of OpenFST. I made some cosmetic changes to allow the project to compile correctly.

Note, there are still a ton of warnings during compilation. I haven't made thorough checks to see if everything works (it seems to), but it does compile everything.

eginhard commented 5 days ago

I do have a fork where I merged some of the fixes made in various PRs here. I used it to publish a PyPI package with the prebuilt Python bindings and all necessary OpenFST binaries. I could update that to OpenFST 1.8.3

danijel3 commented 5 days ago

The reason I did this is because I used Phonetisaurus extensively with Kaldi and they moved on to 1.8.3. I do recommend the update for standards adherence, but it feels to me that there are probably more changes worthwhile than the couple I made here. Oth, I've been using it in this state for a few hours and so far so good...

danijel3 commented 5 days ago

Thanks for the fork. If you need help with anything just let me know.