search

AdoptOpenJDK / IcedTea-Web

The new home for IcedTea-Web
Other
229 stars 86 forks source link

fixed User Keystore Password Prompt #401

Closed patris70 closed 4 years ago

patris70 commented 5 years ago

Hi,

If user previously used Oracle Java and also had user keystore, Icedtea-Web gets KeyStore Password popup window, because Oracle Java does not set password for user keystore. Here is fix:

Updates to net/sourceforge/jnlp/security/KeystorePasswordAttempter.java Change Line 128 From:

static final KeystorePasswordAttempter INSTANCE = new KeystorePasswordAttempter(new SavedPassword(getTrustedCertsPassword()));

To:

static final KeystorePasswordAttempter INSTANCE = new KeystorePasswordAttempter(new SavedPassword(getTrustedCertsPassword()), new SavedPassword("".toCharArray()));

judovana commented 5 years ago

Please provide pull request. Also can this not break keystores with other then "" saved password?

patris70 commented 5 years ago

@judovana no, not break keystore, ojdkbuild has added too: https://github.com/ojdkbuild/ojdkbuild/issues/99

andreiacsantos commented 9 months ago

Is this issue already fix in version 1.8.8? Some of our clients are still getting the pop up multiple times when they try to use icedTeaWeb.