search

AdoptOpenJDK / TSC

The AdoptOpenJDK Technical Steering Committee - Also acts as the knowledge portal for the Adopt OpenJDK GitHub projects
71 stars 33 forks source link

Promote AdoptOpenJDK Version jdk-14+36.1_openj9-0.19.0 #146

Closed lumpfish closed 4 years ago

lumpfish commented 4 years ago

Java Version: jdk-14+36.1_openj9-0.19.0 https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk14-pipeline/70

@AdoptOpenJDK/tsc please can somebody +1 this request?

lumpfish commented 4 years ago

The download URLs for OpenJDK14 with OpenJ9 promoted via (https://github.com/AdoptOpenJDK/TSC/issues/143) are incorrect - the U is missing in OpenJDK14U.

I think that https://github.com/AdoptOpenJDK/openjdk-build/commit/ccecaa5e957c4e34a82352a116cc42cee3608484 and https://github.com/AdoptOpenJDK/openjdk-build/commit/e8cb8d5384484d1df4a9656f4776b0034897c2db changed the way the file is named, but those changes were made after the openj9 builds were complete. @gdams - can you confirm that so we can add this extra file name check to the RELEASING.md documentation.

I have rerun the builds under https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk14-pipeline/70. I submitted with 'Build number ="1"'. The file names are now correct. I assume that if these builds are promoted as release 'jdk-14+36.1_openj9-0.19.0' then those build would then be returned as 'latest' via the API. @gdams - please can you confirm that too?

lumpfish commented 4 years ago

Actually, jdk14 is not a "U" release at all - the upstream repository is jdk/jdk14, not jdk-updates/jdk14u, but we seem to have named the download files for the GA with the "U" for previous releases. Was whether this naming was "correct" decided at some point?

gdams commented 4 years ago

@lumpfish we built the hotspot release from https://github.com/AdoptOpenJDK/openjdk-jdk14u. 14u and 14 are identical right now

lumpfish commented 4 years ago

I see. The repository the openj9 release is built from https://github.com/ibmruntimes/openj9-openjdk-jdk14/ was mirrored from jdk/jdk14, with a plan to switch to jdk-updates/jdk14u after the GA release.

lumpfish commented 4 years ago

Promoted: https://github.com/AdoptOpenJDK/openjdk14-binaries/releases/tag/jdk-14+36.1_openj9-0.19.0 https://adoptopenjdk.net/?variant=openjdk14&jvmVariant=openj9