search

AdoptOpenJDK / jitwatch

Log analyser / visualiser for Java HotSpot JIT compiler. Inspect inlining decisions, hot methods, bytecode, and assembly. View results in the JavaFX user interface.
Other
3.06k stars 437 forks source link

Fix Java 11+ builds for Maven and Gradle #310

Closed garyttierney closed 5 years ago

garyttierney commented 5 years ago

Currently the Maven POM points to early access builds of OpenJFX which are now (seemingly?) unavailable. I've updated these to use the correct versions under each version of Java, and added a fallback profile to use the latest available for future unreleased versions of Java.

The Gradle build has been updated to support building under both Java 7/8 and Java 11 onwards in the same manner as Maven and some of the root projects build script has been cleaned up to move UI specific configuration into the JDK 7/8 build.

Both build systems are now capable of producing fat jars by using their packaging goal (gradle assemble, mvn package).

Fixes #308.

chriswhocodes commented 5 years ago

Hi @garyttierney Thanks for the PR, it seems to work fine with JDK11 but I've got a failing unit test on later JDKs (I stupidly made a test rely on a JDK class that is no longer around). I'll merge this PR and then fix up the test. Many thanks, Chris

chriswhocodes commented 5 years ago

Fixed the broken test. Confirmed your patch works fine. Thank you!