search

AdoptOpenJDK / jitwatch

Log analyser / visualiser for Java HotSpot JIT compiler. Inspect inlining decisions, hot methods, bytecode, and assembly. View results in the JavaFX user interface.
Other
3.06k stars 437 forks source link

Unsued javafx import in util/DisassemblyUtil.java cause build failure #317

Closed fthevenet closed 4 years ago

fthevenet commented 4 years ago

Hi,

When attempting to build JITWatch with a JDK which does not embed JavaFX, it fails with the following error:

> Task :core:compileJava FAILED
C:\Users\ftt2\sources\fthevenet\jitwatch\core\src\main\java\org\adoptopenjdk\jitwatch\util\DisassemblyUtil.java:14: error: package com.sun.javafx.scene.control.behavior does not exist
import com.sun.javafx.scene.control.behavior.SliderBehavior;

This is caused by a spurious import of com.sun.javafx.scene.control.behavior.SliderBehavior in org/adoptopenjdk/jitwatch/util/DisassemblyUtil.java.

Removing the unused import makes it possible to build JITWatch using Gradle with any flavor of OpenJDK (not only the ones including javaFX).