JITWatch is ignoring LD_LIBRARY_PATH on Linux when searching for hsdis

AdoptOpenJDK / jitwatch

Log analyser / visualiser for Java HotSpot JIT compiler. Inspect inlining decisions, hot methods, bytecode, and assembly. View results in the JavaFX user interface.

Other

3.06k stars 437 forks source link

JITWatch is ignoring LD_LIBRARY_PATH on Linux when searching for hsdis #327

Closed Tech-Risk-Chris-zz closed 4 years ago

Tech-Risk-Chris-zz commented 4 years ago

Not all developers have sudo access to their java installation to copy the shared library for HSDIS there.

OpenJDK recommends using LD_LIBRARY_PATH to help Java find the hsdis shared library anyway, which works like a charm for -XX:+PrintAssembly and similar.

JITWatch does not look there for HSDIS though.

I have a patch proposal (see attached txt file), but I cannot quite get your formatting right, otherwise this would be a pull request :)

jitWatch-patch-20200901-1227.patch.txt

chriswhocodes commented 4 years ago

Thanks! Added your patch in https://github.com/AdoptOpenJDK/jitwatch/commit/567b85bb77ef8a880f84e8d124f9d6ccafcafc14