AdoptOpenJDK / openjdk-api

DEPRECATED and replaced by of https://github.com/AdoptOpenJDK/openjdk-api-v3 - See README
https://api.adoptopenjdk.net/README
Apache License 2.0
15 stars 15 forks source link

Change in results from API for jdk8 hotspot query #182

Closed smlambert closed 5 years ago

smlambert commented 5 years ago

The API url that testing used to use to pick up binaries no longer works (not sure if its because of the addition of extra binaries on that API), is there a better URL to use?

That query used to automatically download an SDK build: https://api.adoptopenjdk.net/v2/binary/nightly/openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal

now returns: Multiple binaries match request: [ { “os”: “linux”, “architecture”: “x64", “binary_type”: “jdk”, “openjdk_impl”: “hotspot”, “binary_name”: “OpenJDK8U-jdk_x64_linux_hotspot-jfr_2019-10-01-11-17.tar.gz”, “binary_link”: “https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u-2019-10-01-11-17/OpenJDK8U-jdk_x64_linux_hotspot-jfr_2019-10-01-11-17.tar.gz”, “binary_size”: 104859159, “checksum_link”: “https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u-2019-10-01-11-17/OpenJDK8U-jdk_x64_linux_hotspot-jfr_2019-10-01-11-17.tar.gz.sha256.txt”, “version”: “8”, “version_data”: { “openjdk_version”: “jdk8u-2019-10-01-11-17" }, “heap_size”: “normal”, “download_count”: 9, “updated_at”: “2019-10-01T11:19:40Z” }, { “os”: “linux”, “architecture”: “x64”, “binary_type”: “jdk”, “openjdk_impl”: “hotspot”, “binary_name”: “OpenJDK8U-jdk_x64_linux_hotspot_2019-10-01-11-17.tar.gz”, “binary_link”: “https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u-2019-10-01-11-17/OpenJDK8U-jdk_x64_linux_hotspot_2019-10-01-11-17.tar.gz”, “binary_size”: 104505829, “checksum_link”: “https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u-2019-10-01-11-17/OpenJDK8U-jdk_x64_linux_hotspot_2019-10-01-11-17.tar.gz.sha256.txt”, “version”: “8", “version_data”: { “openjdk_version”: “jdk8u-2019-10-01-11-17” }, “heap_size”: “normal”, “download_count”: 8, “updated_at”: “2019-10-01T11:19:33Z” } ]

Am guessing because JFR is now built and included that we need to use a different query to download SDK (which implies we need to update our test scripts). Was this an intentional change to the API?

At the moment is someone wants to use a test Grinder job and sets it to pick up the nightly build, it fails in setup:

17:13:28 curl -OLJks https://api.adoptopenjdk.net/v2/binary/nightly/openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal 17:13:29 unzip file: openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal ... 17:13:29
17:13:29 gzip: openjdk8?openjdk_impl=hotspot&os=linux&arch=x64&release=latest&type=jdk&heap_size=normal: not in gzip format 17:13:29 tar: This does not look like a tar archive

Been happening for quite some time, but doesn't look like anyone has reported it yet.