AdoptOpenJDK / openjdk-api

DEPRECATED and replaced by of https://github.com/AdoptOpenJDK/openjdk-api-v3 - See README
https://api.adoptopenjdk.net/README
Apache License 2.0
15 stars 15 forks source link

Latest release does not show latest release for all platforms #189

Closed bmarwell closed 4 years ago

bmarwell commented 4 years ago

Hi,

at the time of writing, we have openjdk11 win x64 11.0.5+10.1 but openjdk11 linux x64 11.0.5+10 (notice the missing .1 at the end).

That said, this api call will output those versions each:

# win: 10.1
https://api.adoptopenjdk.net/v2/info/releases/openjdk11?openjdk_impl=openj9&type=jdk&os=windows&release=latest&heap_size=normal&arch=x64
# linux: 10
https://api.adoptopenjdk.net/v2/info/releases/openjdk11?openjdk_impl=openj9&type=jdk&os=linux&release=latest&heap_size=normal&arch=x64

The API spec says you can suppliy multiple values like so:

# notice: &os=linux&os=windows&release=latest
https://api.adoptopenjdk.net/v2/info/releases/openjdk11?openjdk_impl=openj9&type=jdk&os=linux&os=windows&release=latest&heap_size=normal&arch=x64

This will only output the latest version for windows, because it seems that version filtering is done first.

I think the API should return two releases in this case. If not, there should be an appropriate call "latest release for all oses, one each" and/or a hint on the website.

Thanks! :)

karianna commented 4 years ago

@johnoliver probably worth checking v3, if it's solved there then we can close this as v3 will be released soon.

johnoliver commented 4 years ago

This bug will not apply to v3 as v3 does not allow multiple parameters

karianna commented 4 years ago

This bug will not apply to v3 as v3 does not allow multiple parameters

OK, if v3 comes out in the next couple of weeks we can close this and migrate folks.

bmarwell commented 4 years ago

Thanks, works just fine :)