search

AdoptOpenJDK / openjdk-api

DEPRECATED and replaced by of https://github.com/AdoptOpenJDK/openjdk-api-v3 - See README
https://api.adoptopenjdk.net/README
Apache License 2.0
15 stars 15 forks source link

Deactivated V2 api server ? #208

Closed nvuillam closed 3 years ago

nvuillam commented 3 years ago

Some days ago, it still worked, but now it seems that it always returns "Not found"

Ex: https://api.adoptopenjdk.net/v2/info/releases/openjdk11?type=jdk&openjdk_impl=hotspot&release=latest&os=linux&arch=x64

image

I am a user of njre which is based on v2 api

nvuillam commented 3 years ago

@karianna the error remains... please can we reopen the issue until it is fixed in production ? Thanks

karianna commented 3 years ago

I get a response:


{
  "release_name": "jdk-11.0.9+11.1",
  "release_link":
"https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/tag/jdk-11.0.9%2B11.1",
  "timestamp": "2020-10-25T13:31:15Z",
  "release": true,
  "binaries": [
    {
      "os": "linux",
      "architecture": "x64",
      "binary_type": "jdk",
      "openjdk_impl": "hotspot",
      "binary_name": "OpenJDK11U-jdk_x64_linux_hotspot_11.0.9_11.tar.gz",
      "binary_link":
"https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.9%2B11.1/OpenJDK11U-jdk_x64_linux_hotspot_11.0.9_11.tar.gz",
      "binary_size": 194731117,
      "checksum_link":
"https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.9%2B11.1/OpenJDK11U-jdk_x64_linux_hotspot_11.0.9_11.tar.gz.sha256.txt",
      "version": "11",
      "version_data": {
        "openjdk_version": "11.0.9+11.1",
        "semver": "11.0.9+11"
      },
      "heap_size": "normal",
      "download_count": 36048,
      "updated_at": "2020-10-25T14:43:33Z"
    }
  ],
  "download_count": 142558
}

Maybe check brower cache?

Cheers, Martijn

On Mon, 9 Nov 2020 at 15:03, Nicolas Vuillamy notifications@github.com wrote:

@karianna https://github.com/karianna the error remains... please can we reopen the issue until it is fixed in production ? Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdoptOpenJDK/openjdk-api/issues/208#issuecomment-724069348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABME2HQRFQUSMHZF5ZLHYLSPAAF7ANCNFSM4TOONRMA .

nvuillam commented 3 years ago

Locally i still don't have response image

Same from CircleCI servers, as you can see there -> https://app.circleci.com/pipelines/github/nvuillam/node-java-caller/76/workflows/6f4d2f7d-fbd5-47a0-b56a-e3a9c52cc180/jobs/277

Is there some restrictions about access/authentication that weren't there before ?

karianna commented 3 years ago

@nvuillam Will continue to look! As an aside we will be removing this API in the future, have you looked at moving to our v3 API?

ParkerM commented 3 years ago

Probably related to #198, #190

I think the issue is because the V2 API uses a local filesystem cache, so whenever it restarts it forces a full refresh which basically crawls every GitHub release, which takes a longer and longer time as the number of releases grow. While the full refresh is running then a 404 will be returned for any not-yet-cached releases.

joschi commented 3 years ago

Locally i still don't have response

@nvuillam As you can see from the output of your command, you're not quoting the URL correctly and instead created 4 background jobs in your shell.

The URL you've been requesting is https://api.adoptopenjdk.net/v2/info/releases/openjdk11?type=jdk. Everything after the first (and each following) ampersand (&) is creating a background job.

See https://linuxhandbook.com/run-process-background/ and https://www.gnu.org/software/bash/manual/html_node/Job-Control-Basics.html#index-background for details.

joschi commented 3 years ago

@karianna There seems to be some problem with requesting OpenJDK 11 data from the API specifically.

https://api.adoptopenjdk.net/v2/info/releases/openjdk8 and https://api.adoptopenjdk.net/v2/info/releases/openjdk11 are working, but https://api.adoptopenjdk.net/v2/info/releases/openjdk11 is not working.

karianna commented 3 years ago

Yeah, it's the recent 11.0.9.1 release (upstream) that broke semver and has been causing a bit of chaos. Hopefully, we'll get this sorted in the next 24 hours or so. I do recommend a migration plan to v3 regardless :-)

Cheers, Martijn

On Mon, 9 Nov 2020 at 20:58, Jochen Schalanda notifications@github.com wrote:

@karianna https://github.com/karianna There seems to be some problem with requesting OpenJDK 11 data from the API specifically.

https://api.adoptopenjdk.net/v2/info/releases/openjdk8 and https://api.adoptopenjdk.net/v2/info/releases/openjdk11 are working, but https://api.adoptopenjdk.net/v2/info/releases/openjdk11 is not working.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AdoptOpenJDK/openjdk-api/issues/208#issuecomment-724274114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABME2BZMOEUH66PGAADRGTSPBJXTANCNFSM4TOONRMA .

nvuillam commented 3 years ago

@karianna > I'm not a contributor to njre , just a dependent user ^^ If I had time i could check to migrate to V3... but for now I unfortunately have more urgent priorities ^^ I just posted an issue there on the repo to see if someone can do the migration to V3

@joschi > The curl bad example was just a typo, sorry ^^

joschi commented 3 years ago

@nvuillam It's working again:

# curl -i 'https://api.adoptopenjdk.net/v2/info/releases/openjdk11?type=jdk&openjdk_impl=hotspot&release=latest&os=linux&arch=x64'
HTTP/2 200
date: Tue, 10 Nov 2020 07:15:11 GMT
content-type: application/json; charset=utf-8
content-length: 1044
set-cookie: __cfduid=dba724994617a38a238d6ffafa80d3ba21604992509; expires=Thu, 10-Dec-20 07:15:09 GMT; path=/; domain=.adoptopenjdk.net; HttpOnly; SameSite=Lax
x-powered-by: Express
access-control-allow-origin: *
etag: W/"414-OXUeQeGTY17OIxpfQ/98byjDgMM"
set-cookie: 479839c2f6be56b9d980c062ff412257=01412afc6ad64f22bf10cf7b0cefc82f; path=/; HttpOnly; Secure
cache-control: private
cf-cache-status: DYNAMIC
cf-request-id: 06529b3f1300001649ab9f4000000001
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
server: cloudflare
cf-ray: 5efdfb11b92c1649-MUC

{
  "release_name": "jdk-11.0.9+11.1",
  "release_link": "https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/tag/jdk-11.0.9%2B11.1",
  "timestamp": "2020-10-25T13:31:15Z",
  "release": true,
  "binaries": [
    {
      "os": "linux",
      "architecture": "x64",
      "binary_type": "jdk",
      "openjdk_impl": "hotspot",
      "binary_name": "OpenJDK11U-jdk_x64_linux_hotspot_11.0.9_11.tar.gz",
      "binary_link": "https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.9%2B11.1/OpenJDK11U-jdk_x64_linux_hotspot_11.0.9_11.tar.gz",
      "binary_size": 194731117,
      "checksum_link": "https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk-11.0.9%2B11.1/OpenJDK11U-jdk_x64_linux_hotspot_11.0.9_11.tar.gz.sha256.txt",
      "version": "11",
      "version_data": {
        "openjdk_version": "11.0.9+11.1",
        "semver": "11.0.9+11"
      },
      "heap_size": "normal",
      "download_count": 37584,
      "updated_at": "2020-10-25T14:43:33Z"
    }
  ],
  "download_count": 147602
}
nvuillam commented 3 years ago

@joschi sorry friend... but still not from my local network and from Circle CI servers :(

https://app.circleci.com/pipelines/github/nvuillam/node-java-caller/76/workflows/4e02876c-b9b5-45ab-b5f4-0c52bddb6cbb/jobs/280 (job runned just now, full of "Not Found" responses)

Same with curl image

joschi commented 3 years ago

Interesting. It seems to be gone again. 🙄

karianna commented 3 years ago

https://api.adoptopenjdk.net/v2/info/releases/openjdk11 is back - it tasks 2-3 to refresh the cache after a service restart - we're looking at a fix for this.

pdefert commented 3 years ago

the problem is still here [https://api.adoptopenjdk.net/v2/info/releases/openjdk8?openjdk_impl=hotspot&os=windows&arch=x64&type=jre&release=latest]

it's intermittent

V3 does not works as well too

karianna commented 3 years ago

We deployed another emergency release this evening, please do try again

nvuillam commented 3 years ago

Some work, some not https://app.circleci.com/pipelines/github/nvuillam/node-java-caller/76/workflows/1a3b7388-06ce-4d40-a4aa-d9a17fa650ee

Maybe a max number of calls from the same ip ?

karianna commented 3 years ago

Not from the end consumer no. The API acts as a proxy so all requests to GitHub come from it and we have inbuilt rate limiting and throttling when we get 'abuse' messages back from GitHub.

We are still running an 8sec outage every 15 mins on the refresh cycle so I suspect you caught that :-(.

We're looking to implement a more permanent data store fix on Monday!

@nvuillam Are you able to connect us to the author on njre so we can get them to move to V3?

nvuillam commented 3 years ago

@karianna > The owner of njre just transferred me the ownership, so yes I can connect you to me :D

I obviously plan to migrate to V3 soon :)

karianna commented 3 years ago

@karianna > The owner of njre just transferred me the ownership, so yes I can connect you to me :D

I obviously plan to migrate to V3 soon :)

Oh, amazing :-) - https://api.adoptopenjdk.net/swagger-ui/ is your gateway :-)