search

AdoptOpenJDK / openjdk-docker

Scripts for creating Docker images of OpenJDK binaries.
https://hub.docker.com/_/adoptopenjdk/
Apache License 2.0
427 stars 237 forks source link

Docker images are built even if there is no changes in corresponding Dockerfiles #307

Closed lde-avaleo closed 4 years ago

lde-avaleo commented 4 years ago

Hi,

We're using adoptopenjdk8 and adoptopenjdk11 images in our microservices derived from alpine-jre dockerhub tag combined with a hash to have a stable repeatable builds. Moreover we're using renovate plugin to track changes - especially security updates - in all external base images we're using so we're up to date with them.

Unfortunatelly we noticed, that both adoptopenjdk8 and adoptopenjdk11 images are built even if there was no any changes in theirs particular Dockerfiles.

e.g. last commit at this moment for adoptopenjdk8 Dockerfile is from 21st March 2020 but new docker image with tag alpine-jre was released to docker hub today - 27th March 2020 - with a new hash of course. That's created a lot of false positive notification about base image changes and cost us time to check it and switch our images to this newest one.

Is it possible to release images only if there are changes in a corresponding Dockerfile of adoptopenjdk image instead of building them all?

Thank you in advance for your help, regards Lukasz Degus

dinogun commented 4 years ago

Agreed, it is not optimal right now though we were aiming to pull in the latest OS images. We should be able to check the base OS docker image release date as well as if there was a change in our release before triggering a rebuild. Should help us reduce the overall time it takes to complete the build job as well.