MacOS debug symbols support

[andrew-m-leonard]

Enable jdk8 support for MacOS dSYM debug symbols

Signed-off-by: Andrew Leonard anleonar@redhat.com

[karianna]

@andrew-m-leonard has this been submitted upstream?

[andrew-m-leonard]

@karianna not yet.... which way would you like to play this?

[karianna]

These changes have all been manually tested I assume? I think in that case you could write into the jdk8u-dev mailing list and say something like "We've been working on this functionality at Adopt, we'd like to add it to 8u, we have a working patch that's tested (paste the contents this PR) but we're looking for advice on whether A.) There's any appetite to add this functionality to 8 and B.) If so have we taken the right approach?"

I think we should go over this PR in a call as well. I'll ping you on Slack

[andrew-m-leonard]

@karianna yes all tested on jdk8 mac. I want to re-test my mac only jdk8 PR now I have taken AIX out of it

[andrew-m-leonard]

@karianna i've sorted out the indenting, makes it a bit more tricky to review, but end result is now consistent. Note the importance of make cmds being "tab" indented that is very important

[andrew-m-leonard]

Test build with latest update: https://ci.adoptopenjdk.net/view/Failing%20Builds/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-hotspot/938/

[andrew-m-leonard]

Hmm, that indent has broken it! need to double check tabs/spaces again!

[andrew-m-leonard]

Good now: https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-hotspot/940/

[karianna]

@andrew-m-leonard you may need to PR into the release branch as well.

[andrew-m-leonard]

@karianna thanks for reminding me

[andrew-m-leonard]

Merged upstream into jdk8u302: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/rev/af65dfd2bea4