search

AdoptOpenJDK / openjdk-jdk8u

JDK8u mirror from mercurial
http://hg.openjdk.java.net/jdk8u/jdk8u/
GNU General Public License v2.0
373 stars 286 forks source link

Do not remove debug files from Windows jdk when debug symbols external #18

Closed andrew-m-leonard closed 3 years ago

andrew-m-leonard commented 3 years ago

With all other platforms the debug symbols when --with-native-debug-symbols=external or zipped is specified are left in the jdk/jre packages, this PR corrects Windows behaviour that currently deletes them.

Signed-off-by: Andrew Leonard anleonar@redhat.com

karianna commented 3 years ago

Hi @andrew-m-leonard this reminded me - did you create the patch file in the openjdk-mirror project for the Mac OS X patch?

andrew-m-leonard commented 3 years ago

Fix merged upstream into jdk8u-dev: https://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/ce0fb3b3283a

karianna commented 3 years ago

Do we remove the patch in the mirror repo as well?

On Tue, 30 Mar 2021 at 09:42, Andrew Leonard @.***> wrote:

Closed #18 https://github.com/AdoptOpenJDK/openjdk-jdk8u/pull/18.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AdoptOpenJDK/openjdk-jdk8u/pull/18#event-4526084961, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABME2BZIOP2WRX67THTMTDTGGFHZANCNFSM4YFGOPQA .

-- Cheers, Martijn (Sent from Gmail Mobile)

andrew-m-leonard commented 3 years ago

@karianna the macOS one yes, i'll do a PR for that, thanks