Custom LED size - Githubissues

Adorkable / node-red-contrib-ui-led

A simple LED status indicator for the Node-RED Dashboard

MIT License

16 stars 12 forks source link

Custom LED size #17

Closed yoiang closed 3 years ago

yoiang commented 5 years ago

Great idea suggested by @Nokomis449 in #3

I imagine it would be a single pixel size or optionally a different width and height pixel size (have to make sure this actually looks good with our current LED).

My instinct is to keep the text at the default text size but should it grow to fill the height?

juggledad commented 4 years ago

+1 for this - or allow the size to be changed in CSS.

yoiang commented 3 years ago

Thinking through some options:

option to have the LED autosize to fit height (and width)
- if disabled can manually select height up to enclosed size if I can get at that, otherwise just 1
@mschuricht feels the LED is too big (#57) compared to the text, potentially option to match text height

Alllsooooo #65 😬

yoiang commented 3 years ago

Automatic resizing to fit height just added to the develop branch here: https://github.com/Adorkable/node-red-contrib-ui-led/commit/44b53a5f324ea49938f7b130852387e74c4d7bdf

Gonna close this when it's merged into the main branch but if people have ideas about sizing beyond automatic or if for some other reason this doesn't seem like a fit please say so here!

yoiang commented 3 years ago

Released in https://github.com/Adorkable/node-red-contrib-ui-led/releases/tag/0.4.6