Adorkable / node-red-contrib-ui-led

A simple LED status indicator for the Node-RED Dashboard
MIT License
16 stars 12 forks source link

Scrolling controls being display on UI #27

Open WombatHollow opened 5 years ago

WombatHollow commented 5 years ago

Describe the bug On some browser/OS combinations, the UI displays controls for vertical scrolling unnecessarily. Scrolling range is limited to one click of the controls. This is always displayed and there appears to be no parameter that can be set to make the UI element higher so it does not need to scroll.

Been seen with W10/Chrome Does not occur on W10/Edge or W10/IE or Droid 9/Chrome

Screenshots Attached

Desktop (please complete the following information):

yoiang commented 5 years ago

Hey @WombatHollow can you post a screenshot of what this looks like? That might clue me into what is happening here

yoiang commented 4 years ago

Will reopen if this is reported again

WombatHollow commented 4 years ago

LED UI scroll bars showing NR1 1 2 Sorry for not responding back in August last year, your request must have got lost in the inbox and was missed, it was you acrtion to closed the report that caught my eye. Just upgrade to NR1.1.2 and latest LED_UI 0.3.3 and the proglem remains on these combinations of OS/Browser at latest or near latest versions.

W10/Chrome W10/Edge

These combinations do not show this problem:

Android(10) on Tab S6/Chrome Android(10) on Tab S6/Samsung internet Android(9) on Note 8/Chrome

yoiang commented 4 years ago

@WombatHollow oh nice! Would you be able to send over the json for the LEDs or the flow as a whole? It'd be great to use the same properties you have on yours. In the meantime I'll try to repro with a basic setup!

WombatHollow commented 4 years ago

[{"id":"1e97aa16.e7a2f6","type":"ping","z":"12f44cb5.337193","name":"Weather Station ping","host":"10.0.0.171","timer":"60","inputs":0,"x":140,"y":700,"wires":[["9f4c83d2.45f0d","a0df4b97.af7eb8"]]},{"id":"1efbff35.ac9cb1","type":"ping","z":"12f44cb5.337193","name":"Pool ping","host":"10.0.0.235","timer":"60","inputs":0,"x":180,"y":660,"wires":[["9f4c83d2.45f0d","72fd4af2.61d874"]]},{"id":"6d773d88.1a3994","type":"ping","z":"12f44cb5.337193","name":"Vege Patch ping","host":"10.0.0.242","timer":"10","inputs":0,"x":160,"y":620,"wires":[["9f4c83d2.45f0d","8816e835.675368"]]},{"id":"2ed0af50.2b067","type":"ui_led","z":"12f44cb5.337193","group":"996b46f6.ffc338","order":14,"width":"","height":"","label":".-VegePatch","colorForValue":[{"color":"Red","value":"Down","valueType":"str"},{"color":"Green","value":"Good","valueType":"str"},{"color":"Yellow","value":"Slow","valueType":"str"},{"color":"Blue","value":"Froze","valueType":"str"}],"name":"VegePatch LED","x":660,"y":620,"wires":[]},{"id":"8816e835.675368","type":"change","z":"12f44cb5.337193","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"(payload = false)? \"Down\" : (payload >2.0) ? \"Slow\" : \"Good\"","tot":"jsonata"}],"action":"","property":"","from":"","to":"","reg":false,"x":440,"y":620,"wires":[["2ed0af50.2b067","62b5b4b3.dda95c"]]},{"id":"c163e6b1.9913f8","type":"ui_led","z":"12f44cb5.337193","group":"996b46f6.ffc338","order":5,"width":"","height":"","label":".-Pool","colorForValue":[{"color":"Red","value":"Down","valueType":"str"},{"color":"Green","value":"Good","valueType":"str"},{"color":"Yellow","value":"Slow","valueType":"str"},{"color":"Blue","value":"Froze","valueType":"str"}],"name":"Pool LED","x":640,"y":660,"wires":[]},{"id":"72fd4af2.61d874","type":"change","z":"12f44cb5.337193","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"(payload = false)? \"Down\" : (payload >2.0) ? \"Slow\" : \"Good\"","tot":"jsonata"}],"action":"","property":"","from":"","to":"","reg":false,"x":440,"y":660,"wires":[["c163e6b1.9913f8"]]},{"id":"5c337833.b83eb8","type":"ui_led","z":"12f44cb5.337193","group":"996b46f6.ffc338","order":8,"width":"","height":"","label":"..-Weather","colorForValue":[{"color":"Red","value":"Down","valueType":"str"},{"color":"Green","value":"Good","valueType":"str"},{"color":"Yellow","value":"Slow","valueType":"str"},{"color":"Blue","value":"Froze","valueType":"str"}],"name":"Weather LED","x":660,"y":700,"wires":[]},{"id":"a0df4b97.af7eb8","type":"change","z":"12f44cb5.337193","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"(payload = false)? \"Down\" : (payload >2.0) ? \"Slow\" : \"Good\"","tot":"jsonata"}],"action":"","property":"","from":"","to":"","reg":false,"x":440,"y":700,"wires":[["5c337833.b83eb8"]]},{"id":"975e0569.1d0b38","type":"ping","z":"12f44cb5.337193","name":"Router ping","host":"10.0.0.001","timer":"60","inputs":0,"x":170,"y":580,"wires":[["4c1a3167.6b6a1"]]},{"id":"681f8993.420f88","type":"ui_led","z":"12f44cb5.337193","group":"996b46f6.ffc338","order":1,"width":"","height":"","label":"Router","colorForValue":[{"color":"Red","value":"Down","valueType":"str"},{"color":"Green","value":"Good","valueType":"str"},{"color":"Yellow","value":"Slow","valueType":"str"},{"color":"Blue","value":"Froze","valueType":"str"}],"name":"Router LED","x":650,"y":580,"wires":[]},{"id":"4c1a3167.6b6a1","type":"change","z":"12f44cb5.337193","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"(payload = false)? \"Down\" : (payload >2.0) ? \"Slow\" : \"Good\"","tot":"jsonata"}],"action":"","property":"","from":"","to":"","reg":false,"x":440,"y":580,"wires":[["681f8993.420f88"]]},{"id":"62b5b4b3.dda95c","type":"ui_led","z":"12f44cb5.337193","group":"c2749915.2e3758","order":6,"width":"4","height":"1","label":"VegePatch","labelPlacement":"left","labelAlignment":"right","colorForValue":[{"color":"Red","value":"Down","valueType":"str"},{"color":"Green","value":"Good","valueType":"str"},{"color":"Yellow","value":"Slow","valueType":"str"},{"color":"Blue","value":"Froze","valueType":"str"}],"name":"VegePatch LED","x":840,"y":620,"wires":[]},{"id":"996b46f6.ffc338","type":"ui_group","z":"","name":"Status","tab":"4fcb4fe9.d6391","order":2,"disp":true,"width":"6","collapse":false},{"id":"c2749915.2e3758","type":"ui_group","z":"","name":"Manual Control","tab":"15398257.058b8e","order":1,"disp":true,"width":"6","collapse":false},{"id":"4fcb4fe9.d6391","type":"ui_tab","z":"","name":"Network","icon":"usb","order":6},{"id":"15398257.058b8e","type":"ui_tab","z":"","name":"Irrigation","icon":"fa-tint","order":2}]

Here is a chunk of the LEDS (not necessarily the same as in image, but thewy all exhibit the same behaviour.