Closed yoiang closed 3 years ago
I did a little digging, too. 🤓
It seems only the initial values are numbers. As soon as you change the size in any way, they end up as strings as well, like "width": "1"
. So this might be a general Dashboard thing.
The problem is this strict comparison.
So, one can either use ==
or convert the width to a number first.
I am seeing another issue that may be related to this issue. When displayed on my iPhone, in portrait orientation, the LED initially shows as a thin vertical slit. If I rotate the device 90 degrees, to landscape mode, the LED displays properly and then even when rotated back to portrait mode. This anomaly began with the 0.4.7 version.
Regards, Bob
I have addressed the bug @kuema you and others had run into with 0.4.8, please let me know if you have any issues!
@bburkett52 let me take some time to reproduce the issue, if it's still happening I'll make a new issue. Thanks so much for reporting it :)
@yoiang,
Thanks you for your work! I have updated to version 0.4.8 and still have the same issue on my phone. All is good on on larger displays.
Regards, Bob
@bburkett52 please track progress on the issue you're seeing #72 !
Reported by kuema here: https://discourse.nodered.org/t/announce-node-red-contrib-ui-led-0-4-6/39472/3
Describe the bug Size of LED grows to incorrect size if going from fixed size to auto size
To Reproduce
auto
1x1
auto
Expected behavior Should return to
auto
sizeScreenshots![](https://aws1.discourse-cdn.com/business6/uploads/nodered/original/3X/d/7/d7c09a049b6ac5013da88f446150d6e3fe52d280.png)
From the flow, looks like width and height are being saved as![](https://aws1.discourse-cdn.com/business6/uploads/nodered/original/3X/8/c/8c5c4dec9b0c854a169538e8dd973723200787ab.png)
strings
Versions