Adorkable / node-red-contrib-ui-led

A simple LED status indicator for the Node-RED Dashboard
MIT License
16 stars 12 forks source link

Can't set label #71

Closed sam-jeffs closed 2 years ago

sam-jeffs commented 3 years ago

Describe the bug When i try to manually set a label it says the node isn't configured properly.

To Reproduce Steps to reproduce the behavior:

  1. set label in LED node
  2. try to deploy

Expected behavior A clear and concise description of what you expected to happen vs what actually happens.

hoping to label my LEDS :)

Screenshots

Screenshot 2021-02-09 at 16 05 59

Versions

Platform

Additional context

Also is it possible to set the label with an incoming message?

yoiang commented 3 years ago

Thank you for the bug report! I need to come up with a better way to message it but 1x1 LEDs cannot fit a label, can you try sizing it to 2x1 and see if that resolves the invalid state?

sam-jeffs commented 3 years ago

That has solved the error, but I'm still not seeing the label... (thanks for the crazy quick response!)

it doesn't appear in the preview or on the web page...

Screenshot 2021-02-09 at 16 16 59
sam-jeffs commented 3 years ago

So adjusting the shape does fix it, if i make it 3x2!

yoiang commented 3 years ago

Oh strange, let me try to reproduce it!

yoiang commented 3 years ago

I haven't been able to get this to happen on my side, do you have a snippet from your flow that I can try it out on?

yoiang commented 2 years ago

I haven't heard back or been able to reproduce it, I'm going to close it for now. If anyone else runs unto this please let us know!